Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12755019: Add 2-lines summary to CC/Address for Wallet items. (Closed)

Created:
7 years, 9 months ago by aruslan
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Add 2-lines summary to CC/Address for Wallet items. This adds functionality, not the final formatting of CC and Address data. BUG=181286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188329

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved ifdefs to wallet_items and wallet_address. #

Patch Set 3 : Rebase. #

Total comments: 4

Patch Set 4 : DisplayNameLine2 -> DisplayNameDetail. #

Total comments: 2

Patch Set 5 : SubLabel and sub-label -> Sublabel and sublabel. Added description. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -34 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.h View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.cc View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M components/autofill/browser/wallet/wallet_address.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/browser/wallet/wallet_address.cc View 1 2 3 1 chunk +15 lines, -1 line 0 comments Download
M components/autofill/browser/wallet/wallet_items.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/browser/wallet/wallet_items.cc View 1 2 3 1 chunk +18 lines, -0 lines 2 comments Download
M ui/base/models/menu_model.h View 1 2 3 4 1 chunk +14 lines, -6 lines 0 comments Download
M ui/base/models/menu_model.cc View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M ui/base/models/simple_menu_model.h View 1 2 3 4 3 chunks +6 lines, -1 line 0 comments Download
M ui/base/models/simple_menu_model.cc View 1 2 3 4 13 chunks +38 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
aruslan
Please take a look and share your thoughts.
7 years, 9 months ago (2013-03-11 23:57:39 UTC) #1
ahutter
https://codereview.chromium.org/12755019/diff/1/components/autofill/browser/wallet/wallet_items.cc File components/autofill/browser/wallet/wallet_items.cc (right): https://codereview.chromium.org/12755019/diff/1/components/autofill/browser/wallet/wallet_items.cc#newcode211 components/autofill/browser/wallet/wallet_items.cc:211: return descriptive_name(); Not sure how often this is actually ...
7 years, 9 months ago (2013-03-12 00:03:13 UTC) #2
Evan Stade
I think you should move the ifdefs into wallet_items.cc, and use the same flow for ...
7 years, 9 months ago (2013-03-12 02:52:01 UTC) #3
aruslan
PTAL; moved the ifdefs to wallet_items and wallet_address and renamed the methods accordingly. https://chromiumcodereview.appspot.com/12755019/diff/1/components/autofill/browser/wallet/wallet_items.cc File ...
7 years, 9 months ago (2013-03-12 23:59:59 UTC) #4
Evan Stade
sweet, lgtm https://chromiumcodereview.appspot.com/12755019/diff/9001/components/autofill/browser/wallet/wallet_address.cc File components/autofill/browser/wallet/wallet_address.cc (right): https://chromiumcodereview.appspot.com/12755019/diff/9001/components/autofill/browser/wallet/wallet_address.cc#newcode222 components/autofill/browser/wallet/wallet_address.cc:222: // TODO(estade): I18N. technically, l10n. https://chromiumcodereview.appspot.com/12755019/diff/9001/components/autofill/browser/wallet/wallet_address.h File ...
7 years, 9 months ago (2013-03-14 01:00:39 UTC) #5
aruslan
Thanks, Evan! isherman@ and sky@ -- please review and apply the OWNERS seal if appropriate: ...
7 years, 9 months ago (2013-03-14 17:35:41 UTC) #6
sky
https://chromiumcodereview.appspot.com/12755019/diff/14001/ui/base/models/menu_model.h File ui/base/models/menu_model.h (right): https://chromiumcodereview.appspot.com/12755019/diff/14001/ui/base/models/menu_model.h#newcode61 ui/base/models/menu_model.h:61: // Returns the sub-label of the item at the ...
7 years, 9 months ago (2013-03-14 19:54:17 UTC) #7
aruslan
Thanks, sky@, PTAL. https://chromiumcodereview.appspot.com/12755019/diff/14001/ui/base/models/menu_model.h File ui/base/models/menu_model.h (right): https://chromiumcodereview.appspot.com/12755019/diff/14001/ui/base/models/menu_model.h#newcode61 ui/base/models/menu_model.h:61: // Returns the sub-label of the ...
7 years, 9 months ago (2013-03-14 20:52:12 UTC) #8
Ilya Sherman
autofill/ LGTM https://chromiumcodereview.appspot.com/12755019/diff/20001/components/autofill/browser/wallet/wallet_items.cc File components/autofill/browser/wallet/wallet_items.cc (right): https://chromiumcodereview.appspot.com/12755019/diff/20001/components/autofill/browser/wallet/wallet_items.cc#newcode215 components/autofill/browser/wallet/wallet_items.cc:215: #endif Hmm, doesn't seem like you need ...
7 years, 9 months ago (2013-03-14 22:01:36 UTC) #9
sky
LGTM
7 years, 9 months ago (2013-03-14 23:07:25 UTC) #10
aruslan
Thank you for reviews, gentlemen! https://chromiumcodereview.appspot.com/12755019/diff/20001/components/autofill/browser/wallet/wallet_items.cc File components/autofill/browser/wallet/wallet_items.cc (right): https://chromiumcodereview.appspot.com/12755019/diff/20001/components/autofill/browser/wallet/wallet_items.cc#newcode215 components/autofill/browser/wallet/wallet_items.cc:215: #endif On 2013/03/14 22:01:37, ...
7 years, 9 months ago (2013-03-14 23:20:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/12755019/20001
7 years, 9 months ago (2013-03-14 23:37:32 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 10:55:49 UTC) #13
Message was sent while issue was closed. 
Change committed as 188329

Powered by Google App Engine
This is Rietveld 408576698