Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 12755018: Merge 145034 "Make RuleData support up to 8191 selectors" (Closed)

Created:
7 years, 6 months ago by Xianzhu
Modified:
7 years, 6 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 145034 "Make RuleData support up to 8191 selectors" > Make RuleData support up to 8191 selectors > https://bugs.webkit.org/show_bug.cgi?id=111663 > > Patch by Philippe Liard <pliard@chromium.org>; on 2013-03-06 > Reviewed by Andreas Kling. > > r125294 made RuleData consume less memory by replacing a pointer with > an index encoded on 12 bits. > This unfortunately breaks Chrome for Android (and others) when a lot of > CSS is used or more precisely when selectorIndex cannot be stored on 12 > bits. > > Threfore this change decreases the number of bits used to store > m_position by 1 (from 19 to 18) and adds this extra bit to > m_selectorIndex so that values up to 8191 can be stored safely without > overflowing. > > * css/RuleSet.h: > (RuleData): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/WebCore/css/RuleSet.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Xianzhu
7 years, 6 months ago (2013-03-11 23:51:53 UTC) #1
Xianzhu
7 years, 6 months ago (2013-03-11 23:52:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r145434.

Powered by Google App Engine
This is Rietveld 408576698