Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 12755010: Remove unused code in google_apis/gaia (Closed)

Created:
7 years, 9 months ago by dcheng
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Andrew T Wilson (Slow), zel, Michael Courage
Visibility:
Public.

Description

Remove unused code in google_apis/gaia BUG=none TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189710

Patch Set 1 #

Patch Set 2 : One more. #

Patch Set 3 : Remove deleted tests. #

Patch Set 4 : Rebase #

Patch Set 5 : Really rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -925 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_constants.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.h View 1 chunk +0 lines, -2 lines 0 comments Download
D google_apis/gaia/oauth2_mint_token_consumer.h View 1 chunk +0 lines, -22 lines 0 comments Download
D google_apis/gaia/oauth2_mint_token_fetcher.h View 1 chunk +0 lines, -104 lines 0 comments Download
D google_apis/gaia/oauth2_mint_token_fetcher.cc View 1 2 3 4 1 chunk +0 lines, -195 lines 0 comments Download
D google_apis/gaia/oauth2_mint_token_fetcher_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D google_apis/gaia/oauth2_revocation_consumer.h View 1 1 chunk +0 lines, -22 lines 0 comments Download
D google_apis/gaia/oauth2_revocation_fetcher.h View 1 chunk +0 lines, -94 lines 0 comments Download
D google_apis/gaia/oauth2_revocation_fetcher.cc View 1 2 3 4 1 chunk +0 lines, -170 lines 0 comments Download
D google_apis/gaia/oauth2_revocation_fetcher_unittest.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M google_apis/google_apis.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
These all appear to be unused, so I'm doing some cleanup.
7 years, 9 months ago (2013-03-11 19:51:46 UTC) #1
dcheng
+some other people who might be interested in this stuff.
7 years, 9 months ago (2013-03-12 17:42:09 UTC) #2
zel
lgtm
7 years, 9 months ago (2013-03-15 22:20:28 UTC) #3
Andrew T Wilson (Slow)
lgtm
7 years, 9 months ago (2013-03-16 11:16:51 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm, but for some profile work coming in the near future, we might want to ...
7 years, 9 months ago (2013-03-18 14:07:08 UTC) #5
zel
Isn't OAuth2AccessTokenFetcher doing exactly the same thing now? On Mon, Mar 18, 2013 at 7:07 ...
7 years, 9 months ago (2013-03-18 16:18:36 UTC) #6
dcheng
TBRing joi for the google_apis.gyp change, since it's just deletions.
7 years, 9 months ago (2013-03-21 22:50:24 UTC) #7
dcheng
7 years, 9 months ago (2013-03-21 22:54:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r189710 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698