Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1275423006: Remove old webkit Object-getOwnPropertyNames test (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev, caitp (gmail), Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove old webkit Object-getOwnPropertyNames test This test enumerates properties on all the builtins and makes sure that they never change. In practice, this just generates busywork when trying to add new language features; I've never seen it catch an accidentally-exposed bit of API. Committed: https://crrev.com/4e0c0571d0feca645a928577026ffe70732e5590 Cr-Commit-Position: refs/heads/master@{#30160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -229 lines) Patch
D test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +0 lines, -135 lines 0 comments Download
D test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +0 lines, -94 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
What do you think?
5 years, 4 months ago (2015-08-11 21:20:19 UTC) #2
rossberg
On 2015/08/11 21:20:19, adamk wrote: > What do you think? LGTM. Never quite got the ...
5 years, 4 months ago (2015-08-13 11:07:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275423006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275423006/1
5 years, 4 months ago (2015-08-13 14:59:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 15:24:35 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 15:24:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e0c0571d0feca645a928577026ffe70732e5590
Cr-Commit-Position: refs/heads/master@{#30160}

Powered by Google App Engine
This is Rietveld 408576698