Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1275403003: Disable warnings when compiling //net/third_party/nss/ssl on iOS. (Closed)

Created:
5 years, 4 months ago by sdefresne
Modified:
5 years, 4 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-sql-unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable warnings when compiling //net/third_party/nss/ssl on iOS. net/third_party/nss/ssl/sslmutex.c uses sem_init/sem_destroy that are deprecated (not supported in fact) on iOS. Disable the warning. BUG=459705 Committed: https://crrev.com/561c2c8aa2fb4f554321ccbd32bbcdfa3dd40b5e Cr-Commit-Position: refs/heads/master@{#342953}

Patch Set 1 #

Patch Set 2 : Add reference to bug #

Patch Set 3 : Rebase on origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M net/third_party/nss/ssl/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
sdefresne
Please take a look.
5 years, 4 months ago (2015-08-07 18:36:56 UTC) #2
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-07 18:52:00 UTC) #3
Ryan Sleevi
Seems like you should file an independent bug for this, before landing the suppression. Otherwise, ...
5 years, 4 months ago (2015-08-07 19:43:24 UTC) #4
sdefresne
On 2015/08/07 at 19:43:24, rsleevi wrote: > Seems like you should file an independent bug ...
5 years, 4 months ago (2015-08-08 08:47:10 UTC) #5
sdefresne
On 2015/08/08 at 08:47:10, sdefresne wrote: > On 2015/08/07 at 19:43:24, rsleevi wrote: > > ...
5 years, 4 months ago (2015-08-11 08:58:21 UTC) #6
Ryan Sleevi
lgtm
5 years, 4 months ago (2015-08-12 00:26:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275403003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275403003/40001
5 years, 4 months ago (2015-08-12 00:29:20 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-12 01:09:06 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 01:09:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/561c2c8aa2fb4f554321ccbd32bbcdfa3dd40b5e
Cr-Commit-Position: refs/heads/master@{#342953}

Powered by Google App Engine
This is Rietveld 408576698