Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1275363002: [IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware Only walk the heap clearing KeyedStoreICs when the dictionary in question belongs to an object that's used as a prototype. This is a temporary mitigation until we have a way to clear such ICs without having to walk the heap. BUG=v8:4335 LOG=y R=yangguo@chromium.org Committed: https://crrev.com/df9822f45aec113e1f557de27c3b0f9e44a57cc4 Cr-Commit-Position: refs/heads/master@{#30076}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -47 lines) Patch
M src/elements.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M src/lookup.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +7 lines, -12 lines 0 comments Download
M src/objects.cc View 11 chunks +25 lines, -26 lines 1 comment Download
M src/runtime/runtime-array.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
5 years, 4 months ago (2015-08-07 13:45:43 UTC) #1
Yang
LGTM https://codereview.chromium.org/1275363002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1275363002/diff/1/src/objects.cc#newcode14647 src/objects.cc:14647: // TODO(verwaest): Remove this hack. Indeed!
5 years, 4 months ago (2015-08-07 21:28:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275363002/1
5 years, 4 months ago (2015-08-07 22:09:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 22:45:01 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 22:45:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df9822f45aec113e1f557de27c3b0f9e44a57cc4
Cr-Commit-Position: refs/heads/master@{#30076}

Powered by Google App Engine
This is Rietveld 408576698