VM thread shutdown.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
@@ skipping 1246 matching lines @@
   return Api::Success();
 }
 
 
 // --- Initialization and Globals ---
 
 DART_EXPORT const char* Dart_VersionString() {
   return Version::String();
 }
 
-DART_EXPORT bool Dart_Initialize(
+DART_EXPORT char* Dart_Initialize(
     const uint8_t* vm_isolate_snapshot,
     Dart_IsolateCreateCallback create,
     Dart_IsolateInterruptCallback interrupt,
     Dart_IsolateUnhandledExceptionCallback unhandled,
     Dart_IsolateShutdownCallback shutdown,
     Dart_FileOpenCallback file_open,
     Dart_FileReadCallback file_read,
     Dart_FileWriteCallback file_write,
     Dart_FileCloseCallback file_close,
     Dart_EntropySource entropy_source) {
   const char* err_msg = Dart::InitOnce(vm_isolate_snapshot,
                                        create, interrupt, unhandled, shutdown,
                                        file_open, file_read, file_write,
                                        file_close, entropy_source);
   if (err_msg != NULL) {
-    OS::PrintErr("Dart_Initialize: %s\n", err_msg);
-    return false;
+    return strdup(err_msg);

[Florian Schneider, 2015/08/19 09:02:03]

What the reason for strdup here? Could you just pass on the const char*?

return err_msg;

This would eliminate the need to free() the return value.

   }
-  return true;
+  return NULL;
 }
 
 
-DART_EXPORT bool Dart_Cleanup() {
+DART_EXPORT char* Dart_Cleanup() {
   CHECK_NO_ISOLATE(Isolate::Current());
   const char* err_msg = Dart::Cleanup();
   if (err_msg != NULL) {
-    OS::PrintErr("Dart_Cleanup: %s\n", err_msg);
-    return false;
+    return strdup(err_msg);
   }
-  return true;
+  return NULL;
 }
 
 
 DART_EXPORT bool Dart_SetVMFlags(int argc, const char** argv) {
   return Flags::ProcessCommandLineFlags(argc, argv);
 }
 
 
 DART_EXPORT bool Dart_IsVMFlagSet(const char* flag_name) {
   return Flags::IsSet(flag_name);
@@ skipping 50 matching lines @@
 
   // Setup default flags in case none were passed.
   Dart_IsolateFlags api_flags;
   if (flags == NULL) {
     Isolate::Flags vm_flags;
     vm_flags.CopyTo(&api_flags);
     flags = &api_flags;
   }
   Isolate* isolate = Dart::CreateIsolate(isolate_name, *flags);
   free(isolate_name);
+  if (isolate == NULL) {
+    *error = strdup("Isolate creation failed");

[Florian Schneider, 2015/08/19 09:02:03]

Same here.

[Ivan Posva, 2015/08/19 09:21:49]

Needs the strdup because of the contract about error life time.

+    return reinterpret_cast<Dart_Isolate>(NULL);
+  }
   {
     StackZone zone(isolate);
     HANDLESCOPE(isolate);
     // We enter an API scope here as InitializeIsolate could compile some
     // bootstrap library files which call out to a tag handler that may create
     // Api Handles when an error is encountered.
     Dart_EnterScope();
     const Error& error_obj =
         Error::Handle(isolate,
                       Dart::InitializeIsolate(snapshot, callback_data));
     if (error_obj.IsNull()) {
   #if defined(DART_NO_SNAPSHOT)
       if (FLAG_check_function_fingerprints) {
         Library::CheckFunctionFingerprints();
       }
   #endif  // defined(DART_NO_SNAPSHOT).
       // We exit the API scope entered above.
       Dart_ExitScope();
       START_TIMER(isolate, time_total_runtime);
       return Api::CastIsolate(isolate);
     }
     *error = strdup(error_obj.ToErrorCString());

[Florian Schneider, 2015/08/19 09:02:03]

Same here.

If I see this correctly, error_obj.ToErrorCString() creates a zone-allocated
C-string, which will be freed with the zone destructor.

[Ivan Posva, 2015/08/19 09:21:49]

We pack it into a malloc'd string since that is the contract we have with the
caller of the API. The reason the contract is "return a string in malloc
memory": The zone that holds the ToErrorCString result is going away two lines
further down.

     // We exit the API scope entered above.
     Dart_ExitScope();
   }
   Dart::ShutdownIsolate();
   return reinterpret_cast<Dart_Isolate>(NULL);
 }
 
 
 DART_EXPORT void Dart_ShutdownIsolate() {
   Isolate* isolate = Isolate::Current();
@@ skipping 4617 matching lines @@
   ASSERT(stream != NULL);
   TimelineEvent* event = stream->StartEvent();
   if (event != NULL) {
     event->AsyncEnd(label, async_id);
     event->Complete();
   }
   return Api::Success();
 }
 
 }  // namespace dart