Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1275323002: Gallery: replace paper-input of rename field with HTMLInputElement. (Closed)

Created:
5 years, 4 months ago by yawano
Modified:
5 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: replace paper-input of rename field with HTMLInputElement. Since ChromeVox does not support Shadow DOM for now, paper-input with Shadow DOM is not accessible. As temporary solution until it supports Shadow DOM, we replace paper-input with HTMLInputElement. BUG=517774 TEST=none Committed: https://crrev.com/d783daa13d1ed54dcaf98c9e1e6c9905a145e0bb Cr-Commit-Position: refs/heads/master@{#342322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 1 chunk +4 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 2 chunks +5 lines, -7 lines 0 comments Download
M ui/file_manager/gallery/js/test_util.js View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/file_manager/integration_tests/remote_call.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 4 months ago (2015-08-07 08:39:33 UTC) #2
fukino
lgtm!
5 years, 4 months ago (2015-08-07 08:44:50 UTC) #3
yawano
On 2015/08/07 08:44:50, fukino wrote: > lgtm! Thank you!
5 years, 4 months ago (2015-08-07 08:45:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275323002/1
5 years, 4 months ago (2015-08-07 08:45:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 09:08:35 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 09:09:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d783daa13d1ed54dcaf98c9e1e6c9905a145e0bb
Cr-Commit-Position: refs/heads/master@{#342322}

Powered by Google App Engine
This is Rietveld 408576698