Update gm so it doe not write the size of the pdf (writeData writes the length of the data too)

Update gm so it doe not write the size of the pdf (writeData writes the length of the data too)

[epoger, 2013-03-15 17:01:45]

Please get Mike to review this, for the reasons given below.

https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode284
gm/gmmain.cpp:284: SkAutoDataUnref data(document.copyToData());
Filed https://code.google.com/p/skia/issues/detail?id=1167 ('update docs for
SkStream.readData() and SkStream.writeData() to indicate length is included') to
Mike.

https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode285
gm/gmmain.cpp:285: return stream.write(data.get()->data(), data.get()->size());
Also, Mike... does stream.write() guarantee that it will always write out all of
the data?  I tried to address this in
https://codereview.appspot.com/7300071/#msg5 , but I never heard back from you
on it.

[edisonn, 2013-03-18 19:49:15]

Mike, should SkStream.writeData() write the length of the stream?

I can fix the documentation if that is the case, of I can fix the writeData
function


On 2013/03/15 17:01:45, epoger wrote:
> Please get Mike to review this, for the reasons given below.
> 
> https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp
> File gm/gmmain.cpp (right):
> 
> https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode284
> gm/gmmain.cpp:284: SkAutoDataUnref data(document.copyToData());
> Filed https://code.google.com/p/skia/issues/detail?id=1167 ('update docs for
> SkStream.readData() and SkStream.writeData() to indicate length is included')
to
> Mike.
> 
> https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode285
> gm/gmmain.cpp:285: return stream.write(data.get()->data(),
data.get()->size());
> Also, Mike... does stream.write() guarantee that it will always write out all
of
> the data?  I tried to address this in
> https://codereview.appspot.com/7300071/#msg5 , but I never heard back from you
> on it.

[epoger, 2013-03-18 22:15:47]

On 2013/03/18 19:49:15, edisonn wrote:
> Mike, should SkStream.writeData() write the length of the stream?
> 
> I can fix the documentation if that is the case, of I can fix the writeData
> function

Edi- please see https://code.google.com/p/skia/issues/detail?id=1167 ('update
docs
for SkStream.readData() and SkStream.writeData() to indicate length is
included'), as mentioned above.
> 
> 
> On 2013/03/15 17:01:45, epoger wrote:
> > Please get Mike to review this, for the reasons given below.
> > 
> > https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp
> > File gm/gmmain.cpp (right):
> > 
> > https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode284
> > gm/gmmain.cpp:284: SkAutoDataUnref data(document.copyToData());
> > Filed https://code.google.com/p/skia/issues/detail?id=1167 ('update docs for
> > SkStream.readData() and SkStream.writeData() to indicate length is
included')
> to
> > Mike.
> > 
> > https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode285
> > gm/gmmain.cpp:285: return stream.write(data.get()->data(),
> data.get()->size());
> > Also, Mike... does stream.write() guarantee that it will always write out
all
> of
> > the data?  I tried to address this in
> > https://codereview.appspot.com/7300071/#msg5 , but I never heard back from
you
> > on it.

[epoger, 2013-03-28 20:20:44]

https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode285
gm/gmmain.cpp:285: return stream.write(data.get()->data(), data.get()->size());
On 2013/03/15 17:01:46, epoger wrote:
> Also, Mike... does stream.write() guarantee that it will always write out all
of
> the data?  I tried to address this in
> https://codereview.appspot.com/7300071/#msg5 , but I never heard back from you
> on it.

The last question here is whether write() is guaranteed to write out all of the
data passed in, or if it might only write out part of it.

Mike?

[edisonn, 2013-03-28 20:29:50]

Mike already replied a few days ago (see mail) 
"It does write the length. More importantly (to me), it writes whatever it needs
to, to allow stream.readData() to work correctly."


On 2013/03/28 20:20:44, epoger wrote:
> https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp
> File gm/gmmain.cpp (right):
> 
> https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode285
> gm/gmmain.cpp:285: return stream.write(data.get()->data(),
data.get()->size());
> On 2013/03/15 17:01:46, epoger wrote:
> > Also, Mike... does stream.write() guarantee that it will always write out
all
> of
> > the data?  I tried to address this in
> > https://codereview.appspot.com/7300071/#msg5 , but I never heard back from
you
> > on it.
> 
> The last question here is whether write() is guaranteed to write out all of
the
> data passed in, or if it might only write out part of it.
> 
> Mike?

[reed1, 2013-03-28 21:02:07]

On 2013/03/28 20:20:44, epoger wrote:
> https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp
> File gm/gmmain.cpp (right):
> 
> https://codereview.chromium.org/12753007/diff/1/gm/gmmain.cpp#newcode285
> gm/gmmain.cpp:285: return stream.write(data.get()->data(),
data.get()->size());
> On 2013/03/15 17:01:46, epoger wrote:
> > Also, Mike... does stream.write() guarantee that it will always write out
all
> of
> > the data?  I tried to address this in
> > https://codereview.appspot.com/7300071/#msg5 , but I never heard back from
you
> > on it.
> 
> The last question here is whether write() is guaranteed to write out all of
the
> data passed in, or if it might only write out part of it.
> 
> Mike?

We have a weird asymmetry in the stream apis (only one?)

- read() returns the number of bytes read
- write() returns bool TRUE if it succeeded (and wrote all of the bytes), else
returns FALSE

[epoger, 2013-05-07 15:30:59]

This CL has been obviated by https://codereview.chromium.org/14824003/ ('Don't
use writeData to write the document in GM.')