sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 12753003: Recognize const/fixed/growable arrays in simple types inferrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 12753003: Recognize const/fixed/growable arrays in simple types inferrer. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 19764)

+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)

@@ -3270,13 +3270,14 @@

bool isListConstructor = false;

computeType(element) {

Element originalElement = elements[node];

- if (identical(originalElement.getEnclosingClass(), compiler.listClass)) {

+ if (Elements.isFixedListConstructorCall(

+ originalElement, node, compiler)) {

isListConstructor = true;

- if (node.arguments.isEmpty) {

- return HType.EXTENDABLE_ARRAY;

- } else {

- return HType.MUTABLE_ARRAY;

- }

+ return HType.FIXED_ARRAY;

+ } else if (Elements.isGrowableListConstructorCall(

+ originalElement, node, compiler)) {

+ isListConstructor = true;

+ return HType.EXTENDABLE_ARRAY;

} else if (element.isGenerativeConstructor()) {

ClassElement cls = element.getEnclosingClass();

return new HType.nonNullExact(cls.thisType, compiler);