Issue 1275223005: Fix UAF on libusb thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1275223005: Fix UAF on libusb thread (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)

Modified:
5 years, 4 months ago

Reviewers:
Reilly Grant (use Gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix UAF on libusb thread BUG=518749 TBR=reillyg@chromium.org Committed: https://crrev.com/3219ab0a9caf806b6dda0fe970869735726a5481 Cr-Commit-Position: refs/heads/master@{#342653}

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	device/usb/usb_context.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275223005/1

5 years, 4 months ago (2015-08-10 17:10:19 UTC) #2

Reilly Grant (use Gerrit)

lgtm but I think there is still a much harder to hit UAF here. https://codereview.chromium.org/1275223005/diff/1/device/usb/usb_context.cc ...

5 years, 4 months ago (2015-08-10 17:14:08 UTC) #3

commit-bot: I haz the power

5 years, 4 months ago (2015-08-10 18:50:30 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3219ab0a9caf806b6dda0fe970869735726a5481
Cr-Commit-Position: refs/heads/master@{#342653}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages