Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1275223003: Ensure that android "release" apps are signed with debug key (Closed)

Created:
5 years, 4 months ago by djsollen
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Ensure that android "release" apps are signed with debug key Committed: https://skia.googlesource.com/skia/+/3a26fc8e9a31e51125c494e1f8605f101ca71d2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M platform_tools/android/apps/sample_app/build.gradle View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/android_install_app View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
djsollen
5 years, 4 months ago (2015-08-10 15:41:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275223003/1
5 years, 4 months ago (2015-08-10 15:47:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-10 15:47:01 UTC) #5
reed1
lgtm
5 years, 4 months ago (2015-08-10 15:56:50 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 15:58:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3a26fc8e9a31e51125c494e1f8605f101ca71d2b

Powered by Google App Engine
This is Rietveld 408576698