Workaround for range map overlaps caused by Android package relocation.

Workaround for range map overlaps caused by Android package relocation.

If there is a range overlap, the cause may be the client correction applied for Android packed relocations.  If this is the case, back out the client correction and retry.

Patch from Simon Baldwin <simonb@chromium.org>;.

https://code.google.com/p/chromium/issues/detail?id=509110

R=simonb@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1480

[ivanpe, 2015-08-08 01:47:35]

ivanpe@chromium.org changed reviewers:
+ digit@chromium.org, mkrebs@chromium.org, simonb@chromium.org,
ted.mielczarek@gmail.com, thestig@chromium.org

[ivanpe, 2015-08-08 01:47:36]

Workaround for range map overlaps caused by Android package relocation.

If there is a range overlap, the cause may be the client correction applied for
Android packed relocations.  If this is the case, back out the client correction
and retry.

Patch from Simon Baldwin <simonb@chromium.org>.

[simonb (inactive), 2015-08-10 12:26:18]

LGTM.

Ideally this workround would only trigger on apparent overlaps caused by the
relocation packing workround in the client, and not on 'genuine' overlaps due to
some other error.

However, I don't think it's possible to differentiate.  At least, not easily
given the data sent by the client.  There is a stream in the dump that contains
the raw /proc/self/maps from which the client parsed this module data, but
re-parsing it here to classify overlap types seems... undesirable.

[ivanpe, 2015-08-10 17:03:33]

Committed patchset #1 (id:1) manually as r1480 (presubmit successful).