Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: runtime/observatory/lib/src/elements/eval_box.dart

Issue 1275163002: Allow users to remove evaluation results. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/eval_box.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/eval_box.dart
diff --git a/runtime/observatory/lib/src/elements/eval_box.dart b/runtime/observatory/lib/src/elements/eval_box.dart
index 957e74a47fc28ac055644b839f8be308f7e2c887..7447aca2769c57835a5fcd19d9fce621f0675c6e 100644
--- a/runtime/observatory/lib/src/elements/eval_box.dart
+++ b/runtime/observatory/lib/src/elements/eval_box.dart
@@ -17,6 +17,7 @@ typedef Future evalType(String text);
class EvalBoxElement extends ObservatoryElement {
@observable String text;
@observable String lineMode = "1-line";
+ int _exprCount = 0;
@published evalType callback;
@observable ObservableList results = toObservable([]);
@@ -39,6 +40,7 @@ class EvalBoxElement extends ObservatoryElement {
// Use provided callback to eval the expression.
if (callback != null) {
var map = toObservable({});
+ map['id'] = (_exprCount++).toString();
map['expr'] = expr;
results.insert(0, map);
callback(expr).then((result) {
@@ -56,5 +58,12 @@ class EvalBoxElement extends ObservatoryElement {
text = targetElement.getAttribute('expr');
}
+ void closeItem(MouseEvent e) {
+ assert(e.target is Element);
+ Element targetElement = e.target;
+ var closeId = targetElement.getAttribute('closeId');
+ results.removeWhere((item) => item['id'] == closeId);
+ }
+
EvalBoxElement.created() : super.created();
}
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/eval_box.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698