mojo/tools/mopy/gtest.py - Issue 1275123002: Report the apptest fixture name for isolated fixture crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/tools/mopy/gtest.py

Issue 1275123002: Report the apptest fixture name for isolated fixture crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/tools/mopy/gtest.py

diff --git a/mojo/tools/mopy/gtest.py b/mojo/tools/mopy/gtest.py

index 947fcaa0dfe32942e121b636151a329444c45f1e..996d23277609699eef31672494e87ba2d942c5b0 100644

--- a/mojo/tools/mopy/gtest.py

+++ b/mojo/tools/mopy/gtest.py

@@ -51,7 +51,8 @@ def run_apptest(config, shell, args, apptest, isolate):

failed = []

for fixture in fixtures:

arguments = args + ['--gtest_filter=%s' % fixture]

- failed.extend(_run_apptest_with_retry(config, shell, arguments, apptest)[1])

+ failures = _run_apptest_with_retry(config, shell, arguments, apptest)[1]

+ failed.extend(failures if failures != [apptest] else [fixture])

# Abort when 20 fixtures, or a tenth of the apptest fixtures, have failed.

# base::TestLauncher does this for timeouts and unknown results.

if len(failed) >= max(20, len(fixtures) / 10):

« no previous file with comments | « no previous file | no next file » | no next file with comments »