Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1275123002: Report the apptest fixture name for isolated fixture crashes. (Closed)

Created:
5 years, 4 months ago by msw
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report the apptest fixture name for isolated fixture crashes. Report specific Suite.Fixture crashes instead of mojo:foo_apptest. Better than reporting 'mojo:foo_apptests' for each of 10 fixtures, eg.: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows/builds/58/steps/app_tests/logs/stdio TODO: Similar reporting (and avoid crashing fixtures) when not isolated. BUG=509880 TEST=Better logging for apptest crashes on isolated fixtures. R=sky@chromium.org Committed: https://crrev.com/d28ff1ecf96d0650a60283be1b73df31d8e9ff65 Cr-Commit-Position: refs/heads/master@{#342228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/tools/mopy/gtest.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 4 months ago (2015-08-06 19:24:54 UTC) #1
sky
LGTM
5 years, 4 months ago (2015-08-06 20:03:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275123002/1
5 years, 4 months ago (2015-08-06 20:13:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/87605)
5 years, 4 months ago (2015-08-06 21:08:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275123002/1
5 years, 4 months ago (2015-08-06 21:50:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 23:20:20 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 23:20:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d28ff1ecf96d0650a60283be1b73df31d8e9ff65
Cr-Commit-Position: refs/heads/master@{#342228}

Powered by Google App Engine
This is Rietveld 408576698