Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: runtime/vm/dart.cc

Issue 1275113003: Endless thread safe timeline recorder (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | runtime/vm/thread.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index 60439a25d691848b9114471543ca755e13fc7ccf..8880a89ad83899e4defa5211695b5d5b810c2ea0 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -33,10 +33,11 @@
namespace dart {
-DEFINE_FLAG(bool, keep_code, false,
- "Keep deoptimized code for profiling.");
+DECLARE_FLAG(bool, complete_timeline);
DECLARE_FLAG(bool, print_class_table);
DECLARE_FLAG(bool, trace_isolates);
+DEFINE_FLAG(bool, keep_code, false,
+ "Keep deoptimized code for profiling.");
Isolate* Dart::vm_isolate_ = NULL;
ThreadPool* Dart::thread_pool_ = NULL;
@@ -308,7 +309,12 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_buffer, void* data) {
const UserTag& default_tag = UserTag::Handle(UserTag::DefaultTag());
isolate->set_current_tag(default_tag);
- isolate->SetTimelineEventRecorder(new TimelineEventRingRecorder());
+ if (FLAG_complete_timeline) {
+ isolate->SetTimelineEventRecorder(new TimelineEventEndlessRecorder());
+ } else {
+ isolate->SetTimelineEventRecorder(new TimelineEventRingRecorder());
+ }
+
if (FLAG_keep_code) {
isolate->set_deoptimized_code_array(
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | runtime/vm/thread.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698