Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1275083002: Don't pass pipeline to GrBatch::generateGeometry() (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -59 lines) Patch
M gm/beziereffects.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrStrokeRectBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrStrokeRectBatch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTestBatch.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
bsalomon
5 years, 4 months ago (2015-08-06 15:41:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275083002/1
5 years, 4 months ago (2015-08-06 15:41:31 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-06 15:41:31 UTC) #4
joshualitt
On 2015/08/06 15:41:31, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 4 months ago (2015-08-06 15:43:17 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 15:52:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fb1141ae1db2ffce479bc46413b008d31cf9d3cc

Powered by Google App Engine
This is Rietveld 408576698