Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1275053003: Suppress console logs when testing locally (Closed)

Created:
5 years, 4 months ago by vsm
Modified:
5 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress console logs when testing locally See #278 - not really a fix though. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8a86ca7bc16f987dbb0750c2581adcc967482672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M karma.conf.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vsm
5 years, 4 months ago (2015-08-06 17:03:56 UTC) #2
Jennifer Messerly
lgtm. it's enough to close the issue though, right? once we restore the prints in ...
5 years, 4 months ago (2015-08-06 17:06:36 UTC) #3
vsm
On 2015/08/06 17:06:36, John Messerly wrote: > lgtm. it's enough to close the issue though, ...
5 years, 4 months ago (2015-08-06 17:13:45 UTC) #4
vsm
5 years, 4 months ago (2015-08-06 17:14:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a86ca7bc16f987dbb0750c2581adcc967482672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698