Issue 127503002: Make QuicPacketWriter keep track of socket writability; expose the

Issue 127503002: Make QuicPacketWriter keep track of socket writability; expose the (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)

Modified:
6 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make QuicPacketWriter keep track of socket writability; expose the underlying writer's state instead of keeping a separate variable in Dispatcher. Eventually we'll thread this to session/connection as suggested in a TODO. Merge internal change: 59055651 R=rch@chromium.org

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -78 lines)			Patch
M	net/quic/quic_connection_test.cc	View	22 chunks	+28 lines, -24 lines	0 comments	Download
M	net/quic/quic_default_packet_writer.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_default_packet_writer.cc	View	4 chunks	+13 lines, -1 line	0 comments	Download
M	net/quic/quic_packet_writer.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_test_writer.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_test_writer.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	4 chunks	+9 lines, -2 lines	2 comments	Download
M	net/tools/quic/quic_default_packet_writer.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_default_packet_writer.cc	View	2 chunks	+18 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.h	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	6 chunks	+14 lines, -9 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher_test.cc	View	4 chunks	+30 lines, -1 line	0 comments	Download
M	net/tools/quic/test_tools/quic_dispatcher_peer.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_dispatcher_peer.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/tools/quic/test_tools/server_thread.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	net/tools/quic/test_tools/server_thread.cc	View	3 chunks	+5 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

https://codereview.chromium.org/127503002/diff/1/net/tools/quic/end_to_end_test.cc File net/tools/quic/end_to_end_test.cc (right): https://codereview.chromium.org/127503002/diff/1/net/tools/quic/end_to_end_test.cc#newcode230 net/tools/quic/end_to_end_test.cc:230: // server_thread_->Pause(); Hi Ryan, Would like to discuss with ...

6 years, 11 months ago (2014-01-08 03:04:20 UTC) #2

Ryan Hamilton

6 years, 11 months ago (2014-01-08 04:05:09 UTC) #3

lgtm

https://codereview.chromium.org/127503002/diff/1/net/tools/quic/end_to_end_te...
File net/tools/quic/end_to_end_test.cc (right):

https://codereview.chromium.org/127503002/diff/1/net/tools/quic/end_to_end_te...
net/tools/quic/end_to_end_test.cc:230: // server_thread_->Pause();
On 2014/01/08 03:04:20, ramant wrote:
> Hi Ryan,
>   Would like to discuss with you how we could enable pause/resume tomorrow.
> thanks.

Sounds good.

Expand Messages | Collapse Messages