Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1275013004: [runtime] Simplify TO_INT32/TO_UINT32 abstract operations. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Jarin, Yang
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Simplify TO_INT32/TO_UINT32 abstract operations. No need to provide TO_INT32/TO_UINT32 functions for every native context, as they can be implemented in terms of TO_NUMBER more easily and efficiently. Also remove the obsolete TO_BOOLEAN_FUN_INDEX from the native contexts. Committed: https://crrev.com/3cc7adc7c4c12d3b054f904359a170b4a5ad43b4 Cr-Commit-Position: refs/heads/master@{#30080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -66 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/array.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/execution.cc View 3 chunks +14 lines, -12 lines 0 comments Download
M src/harmony-atomics.js View 1 chunk +1 line, -1 line 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.js View 6 chunks +1 line, -19 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/v8natives.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
Hey Yang, This is trivial cleanup. Please take a look. Thanks, Benedikt
5 years, 4 months ago (2015-08-06 20:08:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275013004/1
5 years, 4 months ago (2015-08-09 18:50:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-09 19:15:00 UTC) #6
Jarin
lgtm
5 years, 4 months ago (2015-08-10 04:51:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275013004/1
5 years, 4 months ago (2015-08-10 04:52:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 04:54:26 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 04:54:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cc7adc7c4c12d3b054f904359a170b4a5ad43b4
Cr-Commit-Position: refs/heads/master@{#30080}

Powered by Google App Engine
This is Rietveld 408576698