Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1275003004: Remove GrPipelineOptimizations member from GrPipeline (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@opt
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrPipelineOptimizations member from GrPipeline Committed: https://skia.googlesource.com/skia/+/c699873ac7c6b21bbca96053cdb9720c80f69916

Patch Set 1 #

Total comments: 2

Patch Set 2 : more #

Patch Set 3 : tiny #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -99 lines) Patch
M src/gpu/GrBufferedDrawTarget.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.cpp View 5 chunks +14 lines, -10 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrPipeline.h View 1 2 3 3 chunks +6 lines, -18 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 2 3 4 chunks +48 lines, -48 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 2 3 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
https://codereview.chromium.org/1275003004/diff/1/src/gpu/GrPipeline.cpp File src/gpu/GrPipeline.cpp (right): https://codereview.chromium.org/1275003004/diff/1/src/gpu/GrPipeline.cpp#newcode128 src/gpu/GrPipeline.cpp:128: GrPipelineOptimizations::kCanTweakAlphaForCoverage_GrPipelineOptimizationsFlag; will rm extra space before landing. https://codereview.chromium.org/1275003004/diff/1/src/gpu/GrPipeline.h File ...
5 years, 4 months ago (2015-08-10 17:56:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275003004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275003004/60001
5 years, 4 months ago (2015-08-10 18:53:36 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-10 18:53:37 UTC) #5
joshualitt
On 2015/08/10 18:53:37, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 4 months ago (2015-08-10 18:57:24 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 19:01:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c699873ac7c6b21bbca96053cdb9720c80f69916

Powered by Google App Engine
This is Rietveld 408576698