Componentize tab_node_pool to sync_driver

Componentize tab_node_pool to sync_driver

Move tab_node_pool to the sync_driver component.
Updated gn and gyp file.

BUG=512073
Committed: https://crrev.com/7bf4509514c308164521a502da0e30a1f01c2682
Cr-Commit-Position: refs/heads/master@{#343000}

[Abhishek, 2015-08-10 11:53:40]

abhishek.a21@samsung.com changed reviewers:
+ droger@chromium.org, r.kasibhatla@samsung.com

[Abhishek, 2015-08-10 11:53:40]

PTAL!

[droger, 2015-08-10 12:21:20]

droger@chromium.org changed reviewers:
+ zea@chromium.org

[droger, 2015-08-10 12:21:20]

LGTM
+zea as OWNER

It's surprising that you had to create the unit test target for GN. This
probably means that the tests in sync_driver were not run with GN.

zea: do you know if it is intentional that the unittests are not enabled?

https://codereview.chromium.org/1275003003/diff/1/components/sync_driver/BUIL...
File components/sync_driver/BUILD.gn (right):

https://codereview.chromium.org/1275003003/diff/1/components/sync_driver/BUIL...
components/sync_driver/BUILD.gn:105: ":sync_driver",
Looks like you need also
//base
because the test includes base/logging.h

and probably
//sync
because of sync/api/sync_change.h

[pavely, 2015-08-10 23:31:59]

pavely@chromium.org changed reviewers:
+ pavely@chromium.org

[pavely, 2015-08-11 01:25:02]

On 2015/08/10 12:21:20, droger wrote:
> zea: do you know if it is intentional that the unittests are not enabled?
Looks like a few tests from components_tests.gyp are not in BUILD.gn
(signin_unittest_sources, url_matcher_unittest_sources, etc.)
Don't know why though.

[pavely, 2015-08-11 01:25:10]

lgtm

[Abhishek, 2015-08-11 08:16:18]

Updated dependencies.

PTAL #2!

https://codereview.chromium.org/1275003003/diff/1/components/sync_driver/BUIL...
File components/sync_driver/BUILD.gn (right):

https://codereview.chromium.org/1275003003/diff/1/components/sync_driver/BUIL...
components/sync_driver/BUILD.gn:105: ":sync_driver",
On 2015/08/10 12:21:20, droger wrote:
> Looks like you need also
> //base
> because the test includes base/logging.h
> 
I think we are not using it. So I've removed it.

> and probably
> //sync
> because of sync/api/sync_change.h

Done.

[droger, 2015-08-11 11:08:30]

The CQ bit was checked by droger@chromium.org

[droger, 2015-08-11 11:08:30]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/1275003003/#ps20001
(title: "updated dependencies")

[commit-bot: I haz the power, 2015-08-11 11:08:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275003003/20001

[droger, 2015-08-11 11:08:55]

On 2015/08/11 08:16:18, Abhishek wrote:
> Updated dependencies.
> 
> PTAL #2!

Looks good.

[commit-bot: I haz the power, 2015-08-11 11:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 11:19:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Abhishek, 2015-08-11 11:24:28]

abhishek.a21@samsung.com changed reviewers:
+ sdefresne@chromium.org

[Abhishek, 2015-08-11 11:24:28]

+Sylvain for components/BUILD.gn

[droger, 2015-08-11 11:28:05]

Filed http://crbug.com/519366 for the unit tests issue.

[sdefresne, 2015-08-12 07:11:13]

//components lgtm

https://codereview.chromium.org/1275003003/diff/20001/components/sync_driver/...
File components/sync_driver/BUILD.gn (right):

https://codereview.chromium.org/1275003003/diff/20001/components/sync_driver/...
components/sync_driver/BUILD.gn:101: "tab_node_pool_unittest.cc",
Can you also add the unit tests that are listed in
"sync_driver_unittest_sources" in components/components_tests.gypi here too? The
goal is to have the same unit tests running with gyp and gn.

This can be done as a followup CL if you prefer.

[Abhishek, 2015-08-12 07:49:05]

https://codereview.chromium.org/1275003003/diff/20001/components/sync_driver/...
File components/sync_driver/BUILD.gn (right):

https://codereview.chromium.org/1275003003/diff/20001/components/sync_driver/...
components/sync_driver/BUILD.gn:101: "tab_node_pool_unittest.cc",
On 2015/08/12 07:11:13, sdefresne wrote:
> Can you also add the unit tests that are listed in
> "sync_driver_unittest_sources" in components/components_tests.gypi here too?
The
> goal is to have the same unit tests running with gyp and gn.
> 
> This can be done as a followup CL if you prefer.

I'm okay with anything. But IMO its better to raise in follow up CL for bug
http://crbug.com/519366 .

[droger, 2015-08-12 08:08:19]

On 2015/08/12 07:49:05, Abhishek wrote:
>
https://codereview.chromium.org/1275003003/diff/20001/components/sync_driver/...
> File components/sync_driver/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1275003003/diff/20001/components/sync_driver/...
> components/sync_driver/BUILD.gn:101: "tab_node_pool_unittest.cc",
> On 2015/08/12 07:11:13, sdefresne wrote:
> > Can you also add the unit tests that are listed in
> > "sync_driver_unittest_sources" in components/components_tests.gypi here too?
> The
> > goal is to have the same unit tests running with gyp and gn.
> > 
> > This can be done as a followup CL if you prefer.
> 
> I'm okay with anything. But IMO its better to raise in follow up CL for bug
> http://crbug.com/519366 .

I agree, this is probably better as another CL.

[Abhishek, 2015-08-12 09:51:14]

The CQ bit was checked by abhishek.a21@samsung.com

[commit-bot: I haz the power, 2015-08-12 09:51:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275003003/20001

[commit-bot: I haz the power, 2015-08-12 10:00:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-12 10:01:15]

Patchset 2 (id:??) landed as
https://crrev.com/7bf4509514c308164521a502da0e30a1f01c2682
Cr-Commit-Position: refs/heads/master@{#343000}