Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1274993003: Revert of mandoline: Sandbox mojo:browser and mojo:omnibox. (Closed)

Created:
5 years, 4 months ago by Fady Samuel
Modified:
5 years, 4 months ago
Reviewers:
jam, Elliot Glaysher
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mandoline: Sandbox mojo:browser and mojo:omnibox. (patchset #2 id:20001 of https://codereview.chromium.org/1282903002/ ) Reason for revert: This broke --enable-multiprocess on mandoline. Original issue's description: > mandoline: Sandbox mojo:browser and mojo:omnibox. > > BUG=492524 > > Committed: https://crrev.com/7cd4b784ffd31856b32ada4efd2265a4989fd575 > Cr-Commit-Position: refs/heads/master@{#342725} TBR=jam@chromium.org,erg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=492524 Committed: https://crrev.com/411de5c8ce7feaeb3f1d56881a0ea1db7a9aee77 Cr-Commit-Position: refs/heads/master@{#342822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -46 lines) Patch
M components/font_service/public/cpp/font_loader.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/services/core_services/main.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mandoline/ui/aura/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/aura/aura_init.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Fady Samuel
Created Revert of mandoline: Sandbox mojo:browser and mojo:omnibox.
5 years, 4 months ago (2015-08-11 15:21:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274993003/1
5 years, 4 months ago (2015-08-11 15:21:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 15:22:37 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 15:23:10 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/411de5c8ce7feaeb3f1d56881a0ea1db7a9aee77
Cr-Commit-Position: refs/heads/master@{#342822}

Powered by Google App Engine
This is Rietveld 408576698