[GC] Check for incremental marking when a GC is triggered on reaching the external allocation limit

[GC] Check for incremental marking when a GC is triggered on reaching the external allocation limit

We missed a check whether we can actually do incremental marking when starting
it on reaching the external allocation limit.

BUG=chromium:517195
LOG=N

Committed: https://crrev.com/d2bd9517fefabf0d739f29b4ab61f26e88bddb0b
Cr-Commit-Position: refs/heads/master@{#30043}

[Michael Lippautz, 2015-08-06 09:04:00]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2015-08-06 09:48:04]

https://codereview.chromium.org/1274983002/diff/20001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-517195.js (right):

https://codereview.chromium.org/1274983002/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-517195.js:7: // Test requires ASAN.
really?

[Michael Lippautz, 2015-08-06 09:54:26]

https://codereview.chromium.org/1274983002/diff/20001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-517195.js (right):

https://codereview.chromium.org/1274983002/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-517195.js:7: // Test requires ASAN.
On 2015/08/06 09:48:04, Hannes Payer wrote:
> really?

just kidding -- no asan required ;)

[Hannes Payer (out of office), 2015-08-06 09:55:11]

https://codereview.chromium.org/1274983002/diff/40001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-517195.js (right):

https://codereview.chromium.org/1274983002/diff/40001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-517195.js:5: // Flags: --invoke-weak-callbacks
--omit-quit --noincremental-marking --random-seed=866466637
do we really need all the flags?

[Michael Lippautz, 2015-08-06 09:58:20]

https://codereview.chromium.org/1274983002/diff/40001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-517195.js (right):

https://codereview.chromium.org/1274983002/diff/40001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-517195.js:5: // Flags: --invoke-weak-callbacks
--omit-quit --noincremental-marking --random-seed=866466637
On 2015/08/06 09:55:11, Hannes Payer wrote:
> do we really need all the flags?

just kidding -- only --noincremental-marking needed :)

[Hannes Payer (out of office), 2015-08-06 09:59:40]

LGTM

[Michael Lippautz, 2015-08-06 10:00:55]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2015-08-06 10:01:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274983002/60001

[commit-bot: I haz the power, 2015-08-06 10:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 10:30:25]

Try jobs failed on following builders:
  v8_win_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/8419)

[Michael Lippautz, 2015-08-06 10:56:06]

PTAL

Switched to hand-knitted cctest since JS test ran oom on a win bot.

[Hannes Payer (out of office), 2015-08-06 11:02:43]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-08-06 11:02:43]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1274983002/#ps80001
(title: "Switch to knitted cctest")

[commit-bot: I haz the power, 2015-08-06 11:02:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274983002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274983002/80001

[commit-bot: I haz the power, 2015-08-06 11:49:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-06 11:50:09]

Patchset 5 (id:??) landed as
https://crrev.com/d2bd9517fefabf0d739f29b4ab61f26e88bddb0b
Cr-Commit-Position: refs/heads/master@{#30043}

[Michael Lippautz, 2015-09-15 13:08:00]

Patchset #6 (id:100001) has been deleted