Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 1274893004: [Cleanup] Fix a typo in the Autofill.ScanCreditCard.Completed histogram metadata. (Closed)

Created:
5 years, 4 months ago by Ilya Sherman
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Fix a typo in the Autofill.ScanCreditCard.Completed histogram metadata. "units" should be "enum" BUG=none TEST=none R=rouslan@chromium.org Committed: https://crrev.com/53e81458625ef885dc715e67cbb3bb4a1aea914c Cr-Commit-Position: refs/heads/master@{#342380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Ilya Sherman
5 years, 4 months ago (2015-08-06 21:00:14 UTC) #1
please use gerrit instead
lgtm
5 years, 4 months ago (2015-08-06 21:25:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274893004/1
5 years, 4 months ago (2015-08-06 21:26:18 UTC) #4
please use gerrit instead
Did this have any impact on the data collection? To unsubscribe from this group and ...
5 years, 4 months ago (2015-08-06 21:26:38 UTC) #5
Ilya Sherman
On 2015/08/06 21:26:38, Rouslan wrote: > Did this have any impact on the data collection? ...
5 years, 4 months ago (2015-08-06 21:33:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/96105)
5 years, 4 months ago (2015-08-06 23:04:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274893004/1
5 years, 4 months ago (2015-08-07 17:15:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 18:00:12 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:00:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53e81458625ef885dc715e67cbb3bb4a1aea914c
Cr-Commit-Position: refs/heads/master@{#342380}

Powered by Google App Engine
This is Rietveld 408576698