Issue 1274883002: Remove the unused IFX_StreamRead::SetRange() mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1274883002: Remove the unused IFX_StreamRead::SetRange() mechanism. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove the unused IFX_StreamRead::SetRange() mechanism. This, in turn make m_bUseRange always false, so remove it. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8d8a99027d38e3b8d452e7ab8049c310b90e780d

Patch Set 2 : Add protected: #

Total comments: 2

Patch Set 3 : Remove unused instance vars. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -109 lines)			Patch
	M	core/include/fxcrt/fx_stream.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	core/src/fxcrt/extension.h	View	1 2	11 chunks	+11 lines, -103 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://codereview.chromium.org/1274883002/diff/20001/core/src/fxcrt/extension.h File core/src/fxcrt/extension.h (right): https://codereview.chromium.org/1274883002/diff/20001/core/src/fxcrt/extension.h#newcode80 core/src/fxcrt/extension.h:80: FX_FILESIZE m_nOffset; Is this also no longer used? ...

5 years, 4 months ago (2015-08-05 21:05:39 UTC) #2

Tom Sepez

https://codereview.chromium.org/1274883002/diff/20001/core/src/fxcrt/extension.h File core/src/fxcrt/extension.h (right): https://codereview.chromium.org/1274883002/diff/20001/core/src/fxcrt/extension.h#newcode80 core/src/fxcrt/extension.h:80: FX_FILESIZE m_nOffset; On 2015/08/05 21:05:39, Lei Zhang wrote: > ...

5 years, 4 months ago (2015-08-05 22:09:28 UTC) #3