Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1274873002: Detect MIPS DSP and DSPR2 programattically. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Detect MIPS DSP and DSPR2 programattically. Procedure: $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -dM -E - < /dev/null | sort > vanilla.mips $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdsp -dM -E - < /dev/null | sort > dsp.mips $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdspr2 -dM -E - < /dev/null | sort > dspr2.mips $ diff vanilla.mips dsp.mips 239a240,241 > #define __mips_dsp 1 > #define __mips_dsp_rev 1 $ diff vanilla.mips dspr2.mips 239a240,242 > #define __mips_dsp 1 > #define __mips_dsp_rev 2 > #define __mips_dspr2 1 So, defined(__mips_dsp) -> SK_MIPS_HAS_DSP, defined(__mips_dspr2) -> SK_MIPS_HAS_DSPR2. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f62833d9c9075dd1028ef4395e3370d2597d9115

Patch Set 1 #

Patch Set 2 : Only we define this. #

Patch Set 3 : fold through #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -34 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +4 lines, -23 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/opts/SkBlitRow_opts_mips_dsp.cpp View 1 2 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mtklein_C
5 years, 4 months ago (2015-08-05 20:30:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274873002/1
5 years, 4 months ago (2015-08-05 20:30:54 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-05 20:30:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1648)
5 years, 4 months ago (2015-08-05 20:31:49 UTC) #7
reed1
lgtm even nicer if/when we can remove our define entirely
5 years, 4 months ago (2015-08-05 20:49:07 UTC) #8
mtklein_C
On 2015/08/05 20:49:07, reed1 wrote: > lgtm > > even nicer if/when we can remove ...
5 years, 4 months ago (2015-08-05 20:59:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274873002/40001
5 years, 4 months ago (2015-08-05 21:04:06 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 21:17:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f62833d9c9075dd1028ef4395e3370d2597d9115

Powered by Google App Engine
This is Rietveld 408576698