Source/core/frame/SubresourceIntegrity.cpp - Issue 1274713004: Modify SRI and CSP console messages to base64 hashes, not base64url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/SubresourceIntegrity.cpp

Issue 1274713004: Modify SRI and CSP console messages to base64 hashes, not base64url. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More test updates Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/sources/debugger-pause/debugger-pause-on-blocked-script-injection-expected.txt ('k') | Source/core/frame/csp/CSPDirectiveList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/SubresourceIntegrity.cpp

diff --git a/Source/core/frame/SubresourceIntegrity.cpp b/Source/core/frame/SubresourceIntegrity.cpp

index 997d772ec51ec575d8bd632a5bc98c32cd5e26c1..4377bcb82f6deee5da1334c19c3ba02cc7c3a634 100644

--- a/Source/core/frame/SubresourceIntegrity.cpp

+++ b/Source/core/frame/SubresourceIntegrity.cpp

@@ -61,8 +61,7 @@ static bool DigestsEqual(const DigestValue& digest1, const DigestValue& digest2)

static String digestToString(const DigestValue& digest)

{

- // We always output base64url encoded data, even though we use base64 internally.

- return base64URLEncode(reinterpret_cast<const char*>(digest.data()), digest.size(), Base64DoNotInsertLFs);

+ return base64Encode(reinterpret_cast<const char*>(digest.data()), digest.size(), Base64DoNotInsertLFs);

}