Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1274713003: Refactor ClipboardRecentContent singleton creation. (Closed)

Created:
5 years, 4 months ago by sdefresne
Modified:
5 years, 4 months ago
Reviewers:
jif
CC:
chromium-reviews, dcheng, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor ClipboardRecentContent singleton creation. Move the initialization of the ClipboardRecentContent from the component to the embedder since embedder specific information is required (only the application scheme currently, but more embedder specific information will soon be required). Add an helper method to create a ClipboadRecentContentIOS instance from a C++ file (ClipboardRecentContentIOS is defined in an Objective-C++ header). The instance returned is fully initialized and can be registered as the singleton instance. BUG=517017 Committed: https://crrev.com/d369f9805ca82ca90b6b618b45ccc4af27d574a6 Cr-Commit-Position: refs/heads/master@{#342102}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment by jif #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -88 lines) Patch
M components/open_from_clipboard.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content.h View 2 chunks +9 lines, -14 lines 0 comments Download
A components/open_from_clipboard/clipboard_recent_content.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content_ios.h View 1 chunk +21 lines, -18 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content_ios.mm View 3 chunks +26 lines, -17 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm View 4 chunks +39 lines, -39 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm View 1 1 chunk +13 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
sdefresne
Please take a look.
5 years, 4 months ago (2015-08-05 16:49:27 UTC) #2
jif
lgtm https://codereview.chromium.org/1274713003/diff/1/ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm File ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm (right): https://codereview.chromium.org/1274713003/diff/1/ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm#newcode9 ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm:9: #include "ios/public/provider/chrome/browser/chrome_browser_provider.h" s/include/import/
5 years, 4 months ago (2015-08-05 18:41:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274713003/20001
5 years, 4 months ago (2015-08-06 07:26:23 UTC) #6
sdefresne
Thank you. https://codereview.chromium.org/1274713003/diff/1/ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm File ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm (right): https://codereview.chromium.org/1274713003/diff/1/ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm#newcode9 ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm:9: #include "ios/public/provider/chrome/browser/chrome_browser_provider.h" On 2015/08/05 at 18:41:14, jif ...
5 years, 4 months ago (2015-08-06 07:26:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/87258)
5 years, 4 months ago (2015-08-06 09:05:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274713003/20001
5 years, 4 months ago (2015-08-06 09:23:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89587)
5 years, 4 months ago (2015-08-06 10:49:18 UTC) #13
sdefresne
Failures are unrelated (fails on Win bots that have been flaky since this morning). Sending ...
5 years, 4 months ago (2015-08-06 12:09:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274713003/20001
5 years, 4 months ago (2015-08-06 12:09:22 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-06 12:56:47 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 12:57:31 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d369f9805ca82ca90b6b618b45ccc4af27d574a6
Cr-Commit-Position: refs/heads/master@{#342102}

Powered by Google App Engine
This is Rietveld 408576698