Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 12747009: Undeprecating some Element position APIs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/htmlrenamer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 523abdec4b8925c7b3e1eb46a1746e9b54de4380..a868eb0029d73f463c3165bff9f05a6bf61ea991 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -731,37 +731,15 @@ $(ANNOTATIONS)abstract class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
return window.$dom_getComputedStyle(this, pseudoElement);
}
- @deprecated
- int get clientHeight => client.height;
- @deprecated
- int get clientLeft => client.left;
- @deprecated
- int get clientTop => client.top;
- @deprecated
- int get clientWidth => client.width;
-
- @DomName('Element.clientHeight')
- @DomName('Element.clientLeft')
- @DomName('Element.clientTop')
- @DomName('Element.clientWidth')
- Rect get client => new Rect($dom_clientLeft, $dom_clientTop, $dom_clientWidth,
- $dom_clientHeight);
-
- @deprecated
- int get offsetHeight => offset.height;
- @deprecated
- int get offsetLeft => offset.left;
- @deprecated
- int get offsetTop => offset.top;
- @deprecated
- int get offsetWidth => offset.width;
-
- @DomName('Element.offsetHeight')
- @DomName('Element.offsetLeft')
- @DomName('Element.offsetTop')
- @DomName('Element.offsetWidth')
- Rect get offset => new Rect($dom_offsetLeft, $dom_offsetTop, $dom_offsetWidth,
- $dom_offsetHeight);
+ /**
+ * Gets the position of this element relative to the client area of the page.
+ */
+ Rect get client => new Rect(clientLeft, clientTop, clientWidth, clientHeight);
+
+ /**
+ * Gets the offset of this element relative to its offsetParent.
+ */
+ Rect get offset => new Rect(offsetLeft, offsetTop, offsetWidth, offsetHeight);
/**
* Adds the specified text as a text node after the last child of this
« no previous file with comments | « tools/dom/scripts/htmlrenamer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698