Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 12747009: Undeprecating some Element position APIs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 9e74e4fa9d4b08c067295a9f561c995a7a139356..986b7013f25b29350b545fb4c1502377164e888a 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -9600,37 +9600,15 @@ abstract class Element extends Node implements ElementTraversal {
return window.$dom_getComputedStyle(this, pseudoElement);
}
- @deprecated
- int get clientHeight => client.height;
- @deprecated
- int get clientLeft => client.left;
- @deprecated
- int get clientTop => client.top;
- @deprecated
- int get clientWidth => client.width;
-
- @DomName('Element.clientHeight')
- @DomName('Element.clientLeft')
- @DomName('Element.clientTop')
- @DomName('Element.clientWidth')
- Rect get client => new Rect($dom_clientLeft, $dom_clientTop, $dom_clientWidth,
- $dom_clientHeight);
-
- @deprecated
- int get offsetHeight => offset.height;
- @deprecated
- int get offsetLeft => offset.left;
- @deprecated
- int get offsetTop => offset.top;
- @deprecated
- int get offsetWidth => offset.width;
+ /**
+ * Gets the position of this element relative to the client area of the page.
+ */
+ Rect get client => new Rect(clientLeft, clientTop, clientWidth, clientHeight);
- @DomName('Element.offsetHeight')
- @DomName('Element.offsetLeft')
- @DomName('Element.offsetTop')
- @DomName('Element.offsetWidth')
- Rect get offset => new Rect($dom_offsetLeft, $dom_offsetTop, $dom_offsetWidth,
- $dom_offsetHeight);
+ /**
+ * Gets the offset of this element relative to its offsetParent.
+ */
+ Rect get offset => new Rect(offsetLeft, offsetTop, offsetWidth, offsetHeight);
/**
* Adds the specified text as a text node after the last child of this
@@ -9973,19 +9951,19 @@ abstract class Element extends Node implements ElementTraversal {
@DomName('Element.clientHeight')
@DocsEditable
- int get $dom_clientHeight native "Element_clientHeight_Getter";
+ int get clientHeight native "Element_clientHeight_Getter";
@DomName('Element.clientLeft')
@DocsEditable
- int get $dom_clientLeft native "Element_clientLeft_Getter";
+ int get clientLeft native "Element_clientLeft_Getter";
@DomName('Element.clientTop')
@DocsEditable
- int get $dom_clientTop native "Element_clientTop_Getter";
+ int get clientTop native "Element_clientTop_Getter";
@DomName('Element.clientWidth')
@DocsEditable
- int get $dom_clientWidth native "Element_clientWidth_Getter";
+ int get clientWidth native "Element_clientWidth_Getter";
@DomName('Element.firstElementChild')
@DocsEditable
@@ -10001,11 +9979,11 @@ abstract class Element extends Node implements ElementTraversal {
@DomName('Element.offsetHeight')
@DocsEditable
- int get $dom_offsetHeight native "Element_offsetHeight_Getter";
+ int get offsetHeight native "Element_offsetHeight_Getter";
@DomName('Element.offsetLeft')
@DocsEditable
- int get $dom_offsetLeft native "Element_offsetLeft_Getter";
+ int get offsetLeft native "Element_offsetLeft_Getter";
@DomName('Element.offsetParent')
@DocsEditable
@@ -10013,11 +9991,11 @@ abstract class Element extends Node implements ElementTraversal {
@DomName('Element.offsetTop')
@DocsEditable
- int get $dom_offsetTop native "Element_offsetTop_Getter";
+ int get offsetTop native "Element_offsetTop_Getter";
@DomName('Element.offsetWidth')
@DocsEditable
- int get $dom_offsetWidth native "Element_offsetWidth_Getter";
+ int get offsetWidth native "Element_offsetWidth_Getter";
@DomName('Element.previousElementSibling')
@DocsEditable
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698