build/landmines.py - Issue 12747003: Set landmine for build configs which switch from make -> ninja.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/landmines.py

Issue 12747003: Set landmine for build configs which switch from make -> ninja. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/landmines.py

diff --git a/build/landmines.py b/build/landmines.py

index fc8e9575ac30064a0f8c5d32a778a5c7dc561b68..b276e6cb1fc9a6d2dd03dafadea3debf0b16ce4c 100755

--- a/build/landmines.py

+++ b/build/landmines.py

@@ -143,6 +143,8 @@ def get_landmines(target):

add('Fix findbugs errors on android trybots.')

if platform() == 'win' and builder() == 'ninja':

add('Compile on cc_unittests fails due to symbols removed in r185063.')

+ if platform() == 'linux' and builder() == 'ninja':

+ add('Builders switching from make to ninja will clobber on this.')

return landmines

« no previous file with comments | « no previous file | no next file » | no next file with comments »