Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1274673002: Remove reliance on legacy Skia SkPoint3 ctors in FELighting.cpp (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove reliance on legacy Skia SkPoint3 ctors in FELighting.cpp Skia https://codereview.chromium.org/1269383003/ (Remove SK_LEGACY_SKPOINT3_CTORS flag) removes support for these legacy ctors. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200052

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rm extra line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/platform/graphics/filters/FELighting.cpp View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
robertphillips
5 years, 4 months ago (2015-08-05 14:20:34 UTC) #2
Stephen White
LGTM https://codereview.chromium.org/1274673002/diff/1/Source/platform/graphics/filters/FELighting.cpp File Source/platform/graphics/filters/FELighting.cpp (right): https://codereview.chromium.org/1274673002/diff/1/Source/platform/graphics/filters/FELighting.cpp#newcode31 Source/platform/graphics/filters/FELighting.cpp:31: uNit: two blank lines? https://codereview.chromium.org/1274673002/diff/1/Source/platform/graphics/filters/FELighting.cpp#newcode75 Source/platform/graphics/filters/FELighting.cpp:75: const SkPoint3 ...
5 years, 4 months ago (2015-08-05 14:43:54 UTC) #4
robertphillips
https://codereview.chromium.org/1274673002/diff/1/Source/platform/graphics/filters/FELighting.cpp File Source/platform/graphics/filters/FELighting.cpp (right): https://codereview.chromium.org/1274673002/diff/1/Source/platform/graphics/filters/FELighting.cpp#newcode31 Source/platform/graphics/filters/FELighting.cpp:31: On 2015/08/05 14:43:54, Stephen White wrote: > uNit: two ...
5 years, 4 months ago (2015-08-05 16:10:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274673002/20001
5 years, 4 months ago (2015-08-05 16:11:48 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 18:36:26 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200052

Powered by Google App Engine
This is Rietveld 408576698