Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1274663005: Provide a properly-typed ExpectedSizeForVersion() for types that need it (Closed)

Created:
5 years, 4 months ago by Mark Mentovai
Modified:
5 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Provide a properly-typed ExpectedSizeForVersion() for types that need it Rather than declaring ExpectedSizeForVersion() for all process_types types and providing a default NOTREACHED() implementation, this only declares it for process_types that request it by stating PROCESS_TYPE_STRUCT_VERSIONED() in their proctype definition. This also allows the argument to have the correct type, matching the type of the struct’s version field. TEST=crashpad_snapshot_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/402bb216fb2be24d7a81cb7c003ef59ad3c6394d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -78 lines) Patch
M snapshot/mac/process_types.h View 7 chunks +18 lines, -10 lines 0 comments Download
M snapshot/mac/process_types.cc View 6 chunks +97 lines, -64 lines 0 comments Download
M snapshot/mac/process_types/crashreporterclient.proctype View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/mac/process_types/custom.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M snapshot/mac/process_types/dyld_images.proctype View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This is even cleaner.
5 years, 4 months ago (2015-08-07 18:48:34 UTC) #2
Robert Sesek
LGTM
5 years, 4 months ago (2015-08-07 20:25:14 UTC) #3
Mark Mentovai
5 years, 4 months ago (2015-08-07 20:31:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
402bb216fb2be24d7a81cb7c003ef59ad3c6394d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698