Ensure `String.prototype.normalize.length` is `0`

src/i18n.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ECMAScript 402 API implementation.
 
 /**
  * Intl object is a single object that has some named properties,
  * all of which are constructors.
  */
@@ skipping 1977 matching lines @@
 );
 
 
 /**
  * Unicode normalization. This method is called with one argument that
  * specifies the normalization form.
  * If none is specified, "NFC" is assumed.
  * If the form is not one of "NFC", "NFD", "NFKC", or "NFKD", then throw
  * a RangeError Exception.
  */
-OverrideFunction(GlobalString.prototype, 'normalize', function(form) {
-    if (%_IsConstructCall()) {
-      throw MakeTypeError(kOrdinaryFunctionCalledAsConstructor);
-    }
 
-    CHECK_OBJECT_COERCIBLE(this, "String.prototype.normalize");
+function StringNormalizeJS(form) {
+  if (%_IsConstructCall()) {
+    throw MakeTypeError(kOrdinaryFunctionCalledAsConstructor);
+  }
 
-    form = IS_UNDEFINED(form) ? 'NFC' : form;
+  CHECK_OBJECT_COERCIBLE(this, "String.prototype.normalize");
 
-    var NORMALIZATION_FORMS = ['NFC', 'NFD', 'NFKC', 'NFKD'];
+  form = IS_UNDEFINED(form) ? 'NFC' : form;
 
-    var normalizationForm =
-        %_CallFunction(NORMALIZATION_FORMS, form, ArrayIndexOf);
-    if (normalizationForm === -1) {
-      throw MakeRangeError(kNormalizationForm,
-          %_CallFunction(NORMALIZATION_FORMS, ', ', ArrayJoin));
-    }
+  var NORMALIZATION_FORMS = ['NFC', 'NFD', 'NFKC', 'NFKD'];
 
-    return %StringNormalize(this, normalizationForm);
+  var normalizationForm =
+      %_CallFunction(NORMALIZATION_FORMS, form, ArrayIndexOf);
+  if (normalizationForm === -1) {
+    throw MakeRangeError(kNormalizationForm,
+        %_CallFunction(NORMALIZATION_FORMS, ', ', ArrayJoin));
   }
-);
+
+  return %StringNormalize(this, normalizationForm);
+}
+%FunctionSetLength(StringNormalizeJS, 0);

[rossberg, 2015/08/05 14:23:05]

I'd prefer avoiding the runtime call and instead define the function with 0
arguments, using

  var form = %_Argument(0)

in the body. Same in string.js.

[mathias, 2015/08/05 14:28:11]

Done.

+OverrideFunction(GlobalString.prototype, 'normalize', StringNormalizeJS);
 
 
 /**
  * Formats a Number object (this) using locale and options values.
  * If locale or options are omitted, defaults are used.
  */
 OverrideFunction(GlobalNumber.prototype, 'toLocaleString', function() {
     if (%_IsConstructCall()) {
       throw MakeTypeError(kOrdinaryFunctionCalledAsConstructor);
     }
@@ skipping 76 matching lines @@
     }
 
     var locales = %_Arguments(0);
     var options = %_Arguments(1);
     return toLocaleDateTime(
         this, locales, options, 'time', 'time', 'dateformattime');
   }
 );
 
 })