Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1274653002: Ensure `String.prototype.normalize.length` is `0` (Closed)

Created:
5 years, 4 months ago by mathias
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure `String.prototype.normalize.length` is `0` TEST=test/intl/string/normalization BUG=v8:4303 LOG=N Committed: https://crrev.com/e5d5b6700569cd82b389d11e7bc29776911401e5 Cr-Commit-Position: refs/heads/master@{#30030}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Update as per @rossberg’s feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/i18n.js View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/string.js View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M test/intl/string/normalization.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mathias
5 years, 4 months ago (2015-08-05 13:33:36 UTC) #2
rossberg
https://codereview.chromium.org/1274653002/diff/1/src/i18n.js File src/i18n.js (right): https://codereview.chromium.org/1274653002/diff/1/src/i18n.js#newcode2019 src/i18n.js:2019: %FunctionSetLength(StringNormalizeJS, 0); I'd prefer avoiding the runtime call and ...
5 years, 4 months ago (2015-08-05 14:23:05 UTC) #3
mathias
https://codereview.chromium.org/1274653002/diff/1/src/i18n.js File src/i18n.js (right): https://codereview.chromium.org/1274653002/diff/1/src/i18n.js#newcode2019 src/i18n.js:2019: %FunctionSetLength(StringNormalizeJS, 0); On 2015/08/05 at 14:23:05, rossberg wrote: > ...
5 years, 4 months ago (2015-08-05 14:28:11 UTC) #4
rossberg
lgtm
5 years, 4 months ago (2015-08-05 14:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274653002/40001
5 years, 4 months ago (2015-08-05 14:47:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-05 15:11:31 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 15:13:52 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e5d5b6700569cd82b389d11e7bc29776911401e5
Cr-Commit-Position: refs/heads/master@{#30030}

Powered by Google App Engine
This is Rietveld 408576698