Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: Source/core/css/CSSStyleDeclaration.idl

Issue 1274643002: CSSStyleDeclaraction returns empty string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated failing tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/webexposed/internal-properties-should-not-be-exposed-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSStyleDeclaration.idl
diff --git a/Source/core/css/CSSStyleDeclaration.idl b/Source/core/css/CSSStyleDeclaration.idl
index 24fdfbb82bdee6a9d0905e8efd42c79a46506aac..2d30a2d7c9542d03ef3f9e78e1420d69559c2c24 100644
--- a/Source/core/css/CSSStyleDeclaration.idl
+++ b/Source/core/css/CSSStyleDeclaration.idl
@@ -24,14 +24,11 @@
DependentLifetime,
WillBeGarbageCollected
] interface CSSStyleDeclaration {
- // TODO(philipj): cssText should not be nullable.
- [RaisesException=Setter] attribute DOMString? cssText;
+ [RaisesException=Setter] attribute DOMString cssText;
readonly attribute unsigned long length;
getter DOMString item(unsigned long index);
- // TODO(philipj): All DOMString? return types in this interface should be
- // just DOMString (not nullable).
- DOMString? getPropertyValue(DOMString property);
- DOMString? getPropertyPriority(DOMString property);
+ DOMString getPropertyValue(DOMString property);
+ DOMString getPropertyPriority(DOMString property);
// TODO(philipj): The value and priority arguments should have
// [TreatNullAs=EmptyString] and should not be nullable.
[RaisesException] void setProperty(DOMString property, DOMString? value, optional DOMString? priority = null);
« no previous file with comments | « LayoutTests/webexposed/internal-properties-should-not-be-exposed-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698