CSSStyleDeclaraction returns empty string

CSSStyleDeclaraction returns empty string

CSSStyleDeclaration was returning a null value of type object if CSS
property does not exist. This CL updates IDL as per the specification
and returns an empty string when property is not found.

All tests has been updated that was previously expecting null value to
empty string.

BUG=516236
R=philipj, timloh@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200166

[Habib Virji, 2015-08-05 13:27:24]

The CQ bit was checked by habib.virji@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-05 13:27:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274643002/1

[commit-bot: I haz the power, 2015-08-05 15:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 15:13:16]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7...)

[Timothy Loh, 2015-08-06 04:21:34]

LayoutTests/imported/README suggests that we aren't supposed to modify the tests
checked in that directory.

https://codereview.chromium.org/1274643002/diff/20001/Source/core/css/CSSStyl...
File Source/core/css/CSSStyleDeclaration.idl (right):

https://codereview.chromium.org/1274643002/diff/20001/Source/core/css/CSSStyl...
Source/core/css/CSSStyleDeclaration.idl:37: [RaisesException] DOMString?
removeProperty(DOMString property);
This one too? :-)

[tkent, 2015-08-06 04:27:25]

On 2015/08/06 04:21:34, Timothy Loh wrote:
> LayoutTests/imported/README suggests that we aren't supposed to modify the
tests
> checked in that directory.

Right.  We must not update files in LayoutTests/imported/ directory except
*-expected.txt.

[Habib Virji, 2015-08-06 10:22:57]

Thanks tkent and timothy, I have uplaoded new patch -expected.txt for the
failing test.

At the same time I have made a pull request at
https://github.com/w3c/csswg-test/ to support empty string for
getPropertyValue...

[Habib Virji, 2015-08-06 10:23:31]

The CQ bit was checked by habib.virji@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-06 10:23:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274643002/40001

[commit-bot: I haz the power, 2015-08-06 12:23:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 12:23:42]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2015-08-07 01:54:31]

lgtm

[tkent, 2015-08-07 01:57:26]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2015-08-07 01:57:27]

https://codereview.chromium.org/1274643002/diff/40001/LayoutTests/imported/cs...
File
LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-image-threshold-002-expected.txt
(right):

https://codereview.chromium.org/1274643002/diff/40001/LayoutTests/imported/cs...
LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-image-threshold-002-expected.txt:2:
FAIL -0.5 - inline - invalid assert_equals: expected (object) null but got
(string) ""
Does it mean the imported tests are incorrect according to the specification?

[Habib Virji, 2015-08-07 08:03:47]

Yes. As per the specification, getPropertyValue description should return an
empty string but it is checking null return value in W3C test. 

https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface.

[tkent, 2015-08-07 08:14:59]

On 2015/08/07 08:03:47, Habib Virji wrote:
> Yes. As per the specification, getPropertyValue description should return an
> empty string but it is checking null return value in W3C test. 
> 
> https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface.

Thanks.  How about IE and Firefox behavior?

[Habib Virji, 2015-08-07 10:48:55]

IE returns "" empty string but Firefox returns null object.

[tkent, 2015-08-07 12:12:50]

On 2015/08/07 10:48:55, Habib Virji wrote:
> IE returns "" empty string but Firefox returns null object.

Thanks.  lgtm

[Habib Virji, 2015-08-07 12:39:30]

The CQ bit was checked by habib.virji@samsung.com

[commit-bot: I haz the power, 2015-08-07 12:39:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274643002/40001

[Habib Virji, 2015-08-07 12:42:55]

Thanks

[commit-bot: I haz the power, 2015-08-07 14:03:22]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200166