Issue 127463004: Add UninstallApp() method to DriveAPIService interface.

Issue 127463004: Add UninstallApp() method to DriveAPIService interface. (Closed)

Created:
6 years, 11 months ago by kinaba

Modified:
6 years, 11 months ago

Reviewers:
hashimoto

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add UninstallApp() method to DriveAPIService interface. Actual implementation will come later. This CL just addes the interface. BUG=324166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243550

Patch Set 1 #

Total comments: 2

Patch Set 2 : null #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -2 lines)			Patch
M	chrome/browser/drive/drive_api_service.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/drive/drive_api_service.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/drive/drive_service_interface.h	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/drive/dummy_drive_service.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/drive/dummy_drive_service.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/drive/fake_drive_service.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/drive/fake_drive_service.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/drive/gdata_wapi_service.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/drive/gdata_wapi_service.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm https://codereview.chromium.org/127463004/diff/1/chrome/browser/drive/drive_service_interface.h File chrome/browser/drive/drive_service_interface.h (right): https://codereview.chromium.org/127463004/diff/1/chrome/browser/drive/drive_service_interface.h#newcode353 chrome/browser/drive/drive_service_interface.h:353: // Uninstalls a Drive app with the id ...

6 years, 11 months ago (2014-01-08 04:44:13 UTC) #2

kinaba

https://codereview.chromium.org/127463004/diff/1/chrome/browser/drive/drive_service_interface.h File chrome/browser/drive/drive_service_interface.h (right): https://codereview.chromium.org/127463004/diff/1/chrome/browser/drive/drive_service_interface.h#newcode353 chrome/browser/drive/drive_service_interface.h:353: // Uninstalls a Drive app with the id |app_id|. ...

6 years, 11 months ago (2014-01-08 04:45:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/127463004/60001

6 years, 11 months ago (2014-01-08 04:46:23 UTC) #4

Message was sent while issue was closed.

Change committed as 243550

Expand Messages | Collapse Messages