Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4576)

Unified Diff: chrome/browser/io_thread.h

Issue 127463003: Completely disable use of bind() with pseudo-random port selection on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: On Windows, avoid "port selection" in Stable or Beta channels automatically Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.h
diff --git a/chrome/browser/io_thread.h b/chrome/browser/io_thread.h
index ef742bfd49a0febbdb40946d72507f2f1f72057a..ecc6e0f461f271880c92849c2f070cf34c5ef520 100644
--- a/chrome/browser/io_thread.h
+++ b/chrome/browser/io_thread.h
@@ -165,6 +165,7 @@ class IOThread : public content::BrowserThreadDelegate {
Optional<string> trusted_spdy_proxy;
Optional<bool> enable_quic;
Optional<bool> enable_quic_https;
+ Optional<bool> enable_quic_port_selection;
Optional<size_t> quic_max_packet_length;
Optional<net::QuicVersionVector> quic_supported_versions;
Optional<net::HostPortPair> origin_to_force_quic_on;
@@ -274,6 +275,15 @@ class IOThread : public content::BrowserThreadDelegate {
bool ShouldEnableQuicHttps(const CommandLine& command_line,
base::StringPiece quic_trial_group);
+ // Returns true if the selection of the ephemeral port in bind() should be
+ // performed by Chromium, and false if the OS should select the port. The OS
+ // option is used to prevent Windows from posting a security security warning
+ // dialog.
+ // TODO(grt) bug=329255: Detect presence of rule on Windows that allows us to
+ // do port selection without inducing a dialog.
+ bool IOThread::ShouldEnableEnableQuicPortSelection(
+ const CommandLine& command_line);
+
// Returns the maximum length for QUIC packets, based on any flags in
// |command_line| or the field trial. Returns 0 if there is an error
// parsing any of the options, or if the default value should be used.
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698