Completely disable use of bind() with pseudo-random port selection on Windows.

chrome/browser/io_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/io_thread.h"
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 23 matching lines @@
 #include "chrome/browser/net/chrome_network_delegate.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/net/connect_interceptor.h"
 #include "chrome/browser/net/dns_probe_service.h"
 #include "chrome/browser/net/http_pipelining_compatibility_client.h"
 #include "chrome/browser/net/pref_proxy_config_tracker.h"
 #include "chrome/browser/net/proxy_service_factory.h"
 #include "chrome/browser/net/sdch_dictionary_fetcher.h"
 #include "chrome/browser/net/spdyproxy/http_auth_handler_spdyproxy.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/chrome_version_info.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/policy/core/common/policy_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cookie_store_factory.h"
 #include "net/base/host_mapping_rules.h"
 #include "net/base/net_util.h"
 #include "net/base/network_time_notifier.h"
 #include "net/base/sdch_manager.h"
 #include "net/cert/cert_verifier.h"
@@ skipping 914 matching lines @@
   globals_->enable_spdy_compression.CopyToIfSet(
       &params->enable_spdy_compression);
   globals_->enable_spdy_ping_based_connection_checking.CopyToIfSet(
       &params->enable_spdy_ping_based_connection_checking);
   globals_->spdy_default_protocol.CopyToIfSet(
       &params->spdy_default_protocol);
   globals_->trusted_spdy_proxy.CopyToIfSet(
       &params->trusted_spdy_proxy);
   globals_->enable_quic.CopyToIfSet(&params->enable_quic);
   globals_->enable_quic_https.CopyToIfSet(&params->enable_quic_https);
+  globals_->enable_quic_port_selection.CopyToIfSet(
+      &params->enable_quic_port_selection);
   globals_->quic_max_packet_length.CopyToIfSet(&params->quic_max_packet_length);
   globals_->quic_supported_versions.CopyToIfSet(
       &params->quic_supported_versions);
   globals_->origin_to_force_quic_on.CopyToIfSet(
       &params->origin_to_force_quic_on);
   params->enable_user_alternate_protocol_ports =
       globals_->enable_user_alternate_protocol_ports;
 }
 
 net::SSLConfigService* IOThread::GetSSLConfigService() {
@@ skipping 67 matching lines @@
   // The command line flags will be associated with a group that is reported
   // so long as trial is actually queried.
   std::string quic_trial_group =
       base::FieldTrialList::FindFullName(kQuicFieldTrialName);
 
   bool enable_quic = ShouldEnableQuic(command_line, quic_trial_group);
   globals_->enable_quic.set(enable_quic);
   if (enable_quic) {
     globals_->enable_quic_https.set(
         ShouldEnableQuicHttps(command_line, quic_trial_group));
+    globals_->enable_quic_port_selection.set(
+        ShouldEnableEnableQuicPortSelection(command_line));
   }
 
   size_t max_packet_length = GetQuicMaxPacketLength(command_line,
                                                     quic_trial_group);
   if (max_packet_length != 0) {
     globals_->quic_max_packet_length.set(max_packet_length);
   }
 
   net::QuicVersion version = GetQuicVersion(command_line);
   if (version != net::QUIC_VERSION_UNSUPPORTED) {
@@ skipping 28 matching lines @@
                                      base::StringPiece quic_trial_group) {
   if (command_line.HasSwitch(switches::kDisableQuicHttps))
     return false;
 
   if (command_line.HasSwitch(switches::kEnableQuicHttps))
     return true;
 
   return quic_trial_group.starts_with(kQuicFieldTrialHttpsEnabledGroupName);
 }
 
+bool IOThread::ShouldEnableEnableQuicPortSelection(
+      const CommandLine& command_line) {
+  if (command_line.HasSwitch(switches::kDisableQuicPortSelection))
+    return false;
+
+  if (command_line.HasSwitch(switches::kEnableQuicPortSelection))
+    return true;
+
+#if defined(OS_WIN)
+  chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
+  // Avoid picking ports (which might induce a security dialog) when we have a
+  // beta or stable release.  Allow in all other cases, including when we do a
+  // developer build (CHANNEL_UNKNOWN).
+  if (channel == chrome::VersionInfo::CHANNEL_STABLE ||
+          channel == chrome::VersionInfo::CHANNEL_BETA) {
+    // TODO(jar): When we have an API to see if the administrative security
+    // manager will allow port selection without a security dialog, we may
+    // return true if we're sure there will be no security dialog.
+    return false;
+  }
+  return true;
+#else
+  return true;
+#endif
+}
+
 size_t IOThread::GetQuicMaxPacketLength(const CommandLine& command_line,
                                         base::StringPiece quic_trial_group) {
   if (command_line.HasSwitch(switches::kQuicMaxPacketLength)) {
     unsigned value;
     if (!base::StringToUint(
             command_line.GetSwitchValueASCII(switches::kQuicMaxPacketLength),
             &value)) {
       return 0;
     }
     return value;
@@ skipping 28 matching lines @@
   std::string version_flag =
       command_line.GetSwitchValueASCII(switches::kQuicVersion);
   for (size_t i = 0; i < supported_versions.size(); ++i) {
     net::QuicVersion version = supported_versions[i];
     if (net::QuicVersionToString(version) == version_flag) {
       return version;
     }
   }
   return net::QUIC_VERSION_UNSUPPORTED;
 }