Issue 127463002: google_apis: Fix use-after-free of URLFetcher* in ResponseWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127463002: google_apis: Fix use-after-free of URLFetcher* in ResponseWriter (Closed)

Created:
6 years, 11 months ago by hashimoto

Modified:
6 years, 11 months ago

Reviewers:
kinaba

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

google_apis: Fix use-after-free of URLFetcher* in ResponseWriter URLFetcher can be destroyed on the UI thread at any moment, while ResponseWriter works on the IO thread. BUG=331822 TEST=See no crash after following the repro steps described in the BUG.

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	google_apis/drive/base_requests.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	google_apis/drive/base_requests.cc	View		3 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

6 years, 11 months ago (2014-01-08 05:19:32 UTC) #3

Noticed that this fix not the right one because there is a chance for a crash
where url_fetcher_ is destroyed at a timing between l. 147 and l. 148.

Made another fix, PTL at https://codereview.chromium.org/127613002/.

Expand Messages | Collapse Messages