Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: tools/clang/empty_string/tests/test-original.cc

Issue 12746010: Implement clang tool that converts std::string("") to std::string(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove debugging print and add comment. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/empty_string/tests/test-original.cc
diff --git a/tools/clang/empty_string/tests/test-original.cc b/tools/clang/empty_string/tests/test-original.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1de691ca60bcd7d20f745b5855914fd3e4479135
--- /dev/null
+++ b/tools/clang/empty_string/tests/test-original.cc
@@ -0,0 +1,34 @@
+// Test file for the empty string clang tool.
+
+#include <string>
+
+// Tests for std::string declarations.
+void TestDeclarations() { std::string a(""), b("abc"), c(""); }
+
+// Tests for std::string allocated with new.
+void TestNew() {
+ std::string* a = new std::string(""),
+ *b = new std::string("abc"),
+ *c = new std::string(""),
+ *d = new std::string();
+}
+
+// Tests for std::string construction in initializer lists.
+class TestInitializers {
+ public:
+ TestInitializers() : a("") {}
+ TestInitializers(bool) : a(""), b("") {}
+ TestInitializers(double) : a(""), b("cat"), c() {}
+
+ private:
+ std::string a;
+ std::string b;
+ std::string c;
+};
+
+// Tests for temporary std::strings.
+void TestTemporaries(const std::string& reference_argument,
+ const std::string value_argument) {
+ TestTemporaries("", "");
+ TestTemporaries(std::string(""), std::string(""));
+}

Powered by Google App Engine
This is Rietveld 408576698