|
|
Revert 189969 "Add RenderWidgetHost::GetSnapshotFromRenderer met..."
> Add RenderWidgetHost::GetSnapshotFromRenderer method to content/ interface for snapshotting for cases where we might not be able to use CopyFromBackingStore because the browser side can't access the backing store or accelerated surface due to driver issues or WinXP.
>
> Consolidate renderer-side snapshotting into that method and move clients (tabsApi, tabCapture and NTP) to the new method.
>
> Let the Linux CopyFromCompositingSurface always use this since the current one is incorrect if the tab is in the background or is covered by a window.
>
> Remove Linux-GTK snapshotting workarounds.
>
> BUG= 188867, 174957, 132301
>
> Review URL: https://codereview.chromium.org/12881005
TBR=justinlin@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190012
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+187 lines, -168 lines) |
Patch |
 |
M |
chrome/browser/extensions/api/tabs/tabs_api.h
|
View
|
|
2 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/tabs/tabs_api.cc
|
View
|
|
2 chunks |
+24 lines, -24 lines |
0 comments
|
Download
|
|
M |
chrome/browser/thumbnails/thumbnail_tab_helper.cc
|
View
|
|
2 chunks |
+15 lines, -16 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_tab_contents.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A + |
chrome/browser/ui/snapshot_tab_helper.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
A + |
chrome/browser/ui/snapshot_tab_helper.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser_ui.gypi
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/chrome_content_client.cc
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/render_messages.h
|
View
|
|
2 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/renderer/chrome_render_view_observer.h
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/renderer/chrome_render_view_observer.cc
|
View
|
|
3 chunks |
+48 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/web_contents_video_capture_device.cc
|
View
|
|
1 chunk |
+1 line, -9 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_widget_host_impl.h
|
View
|
|
4 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_widget_host_impl.cc
|
View
|
|
4 chunks |
+2 lines, -37 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_widget_host_view_gtk.cc
|
View
|
|
1 chunk |
+41 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl.cc
|
View
|
|
3 chunks |
+29 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/common/view_messages.h
|
View
|
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
content/public/browser/render_widget_host.h
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_widget.h
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_widget.cc
|
View
|
|
2 chunks |
+0 lines, -45 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
12746009:
Revert 189969 "Add RenderWidgetHost::GetSnapshotFromRenderer met..." (Closed)
