Re-implement overscan & Implement Display Rotation

Re-implement overscan & Implement Display Rotation
- Use RootWindow's transform to implement insets
- Update WorksspaceWindowResizerUnittests to use
 UpdateDisplay to update display properly.
- Disable updating display when host window's size has
 changed during the test. This is causing flakyness as
 ConfigureNotify may arrive after the size has changed to
 yet another bounds.
- Re-assign screen rotation to shift-ctrl-refresh.


BUG=119268, 174721
TEST=covered by unittests. manual.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187436

[Jun Mukai, 2013-03-11 02:02:35]

basically lgtm although you should fix the test failures for win7/8_aura bots.

https://codereview.chromium.org/12746002/diff/25001/ash/accelerators/accelera...
File ash/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/12746002/diff/25001/ash/accelerators/accelera...
ash/accelerators/accelerator_controller.cc:155: using internal::DisplayInfo;
using-directive would be better at the top of the file, I guess.

[oshima, 2013-03-11 17:41:41]

sky -> OWNERS review

I'm sending to you as you're currently touching display
code.

https://codereview.chromium.org/12746002/diff/50001/ui/aura/root_window_host.h
File ui/aura/root_window_host.h (right):

https://codereview.chromium.org/12746002/diff/50001/ui/aura/root_window_host....
ui/aura/root_window_host.h:67: virtual void SetInsets(const gfx::Insets& insets)
= 0;
I originally had insets in root_window.h, but moved to
host impl. I now feel having in root_window might have been
better because all other impl has to have empty impl.
I can be convinced either way, so let me know if you have preference.

[sky, 2013-03-11 20:52:13]

LGTM

https://codereview.chromium.org/12746002/diff/56001/ash/display/display_info.h
File ash/display/display_info.h (right):

https://codereview.chromium.org/12746002/diff/56001/ash/display/display_info....
ash/display/display_info.h:31: Rotate0 = 0,
Enums are all caps, eg ROTATE0 (or maybe ROTATE_0).

[oshima, 2013-03-11 21:45:48]

https://codereview.chromium.org/12746002/diff/56001/ash/display/display_info.h
File ash/display/display_info.h (right):

https://codereview.chromium.org/12746002/diff/56001/ash/display/display_info....
ash/display/display_info.h:31: Rotate0 = 0,
On 2013/03/11 20:52:13, sky wrote:
> Enums are all caps, eg ROTATE0 (or maybe ROTATE_0).

Done.

[commit-bot: I haz the power, 2013-03-11 21:47:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/12746002/45002

[commit-bot: I haz the power, 2013-03-11 22:12:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/12746002/65001

[oshima, 2013-03-12 00:55:36]

On 2013/03/11 22:12:41, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/oshima%40chromium.org/12746002/65001

All bots passed in patch 10, but CQ somehow didn't start for rebased patch in
11. I'll submit manually.

[oshima, 2013-03-12 00:57:31]

Committed patchset #11 manually as r187436 (presubmit successful).