Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 127453003: Revert of [telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension. (Closed)

Created:
6 years, 11 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -537 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/telemetry.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/telemetry/telemetry.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap.py View 5 chunks +68 lines, -50 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap_unittest.py View 2 chunks +4 lines, -35 lines 0 comments Download
D tools/telemetry/telemetry/core/bitmaptools/__init__.py View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/telemetry/telemetry/core/bitmaptools/bitmaptools.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D tools/telemetry/telemetry/core/build_extension.py View 1 chunk +0 lines, -53 lines 0 comments Download
M tools/telemetry/telemetry/core/tab.py View 2 chunks +8 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/core/util.py View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
Created Revert of [telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension.
6 years, 11 months ago (2014-01-08 03:21:26 UTC) #1
Lei Zhang
183> Traceback (most recent call last): 183> File "telemetry\core\build_extension.py", line 52, in <module> 183> assert ...
6 years, 11 months ago (2014-01-08 03:22:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/127453003/1
6 years, 11 months ago (2014-01-08 03:22:15 UTC) #3
commit-bot: I haz the power
Can't process patch for file tools/telemetry/telemetry/core/bitmap_unittest.py. Hunk header is incorrect: -29 vs -28; Hunk<(104, 43) ...
6 years, 11 months ago (2014-01-08 03:22:17 UTC) #4
Lei Zhang
On 2014/01/08 03:22:17, I haz the power (commit-bot) wrote: > Can't process patch for file ...
6 years, 11 months ago (2014-01-08 03:23:37 UTC) #5
rmistry
6 years, 10 months ago (2014-02-06 20:51:51 UTC) #6
Message was sent while issue was closed.
On 2014/01/08 03:23:37, Lei Zhang wrote:
> On 2014/01/08 03:22:17, I haz the power (commit-bot) wrote:
> > Can't process patch for file
> tools/telemetry/telemetry/core/bitmap_unittest.py.
> > Hunk header is incorrect: -29 vs -28; Hunk<(104, 43) to (102, 15)>
> 
> Ok, drover it is.

FYI, this 'Hunk header is incorrect' bug in one-click revert has been fixed in
http://crbug.com/341028

Powered by Google App Engine
This is Rietveld 408576698