Issue 127453002: Enable the DesktopAuraTopLevelOwnedPopupResizeTest test for Linux AURA.

Issue 127453002: Enable the DesktopAuraTopLevelOwnedPopupResizeTest test for Linux AURA. (Closed)

Created:
6 years, 11 months ago by ananta

Modified:
6 years, 11 months ago

Reviewers:
Elliot Glaysher, sky

CC:
chromium-reviews, tfarina, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enable the DesktopAuraTopLevelOwnedPopupResizeTest test for Linux AURA. Added implementation for the DesktopRootWindowHostX11::SetSize function. BUG=330596 R=erg@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243740

Patch Set 4 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	ui/views/widget/widget_unittest.cc	View	1 2 3	2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

lgtm https://codereview.chromium.org/127453002/diff/1/ui/views/widget/widget_unittest.cc File ui/views/widget/widget_unittest.cc (right): https://codereview.chromium.org/127453002/diff/1/ui/views/widget/widget_unittest.cc#newcode1221 ui/views/widget/widget_unittest.cc:1221: // views::DesktopRootWindowHostX11::SetSize function Should you delete more of ...

6 years, 11 months ago (2014-01-08 02:09:20 UTC) #2

ananta

https://codereview.chromium.org/127453002/diff/1/ui/views/widget/widget_unittest.cc File ui/views/widget/widget_unittest.cc (right): https://codereview.chromium.org/127453002/diff/1/ui/views/widget/widget_unittest.cc#newcode1221 ui/views/widget/widget_unittest.cc:1221: // views::DesktopRootWindowHostX11::SetSize function On 2014/01/08 02:09:20, Elliot Glaysher wrote: ...

6 years, 11 months ago (2014-01-08 02:12:33 UTC) #3

ananta

6 years, 11 months ago (2014-01-09 02:00:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r243740 (presubmit successful).

Expand Messages | Collapse Messages