Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Issue 1274433004: Hand over courgette ownership. (Closed)

Created:
5 years, 4 months ago by dgarrett
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hand over courgette ownership. I haven't touched this code in years now. BUG=None Committed: https://crrev.com/a84a20402d4723374468b56075d75ce427042427 Cr-Commit-Position: refs/heads/master@{#344523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M courgette/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Will Harris
lgtm but sad to see you go :(
5 years, 4 months ago (2015-08-11 17:18:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274433004/1
5 years, 4 months ago (2015-08-20 16:56:29 UTC) #4
dgarrett
On 2015/08/11 17:18:59, Will Harris wrote: > lgtm but sad to see you go :( ...
5 years, 4 months ago (2015-08-20 16:56:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 17:08:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a84a20402d4723374468b56075d75ce427042427 Cr-Commit-Position: refs/heads/master@{#344523}
5 years, 4 months ago (2015-08-20 17:09:44 UTC) #7
tommi (sloooow) - chröme
lgtm... looks like none of the owners have touched the code in a long time. ...
5 years, 4 months ago (2015-08-20 17:19:09 UTC) #9
Will Harris
I still touch the code occasionally, and don't mind reviewing the CLs that are coming ...
5 years, 4 months ago (2015-08-20 17:22:31 UTC) #10
eric.georgiades
5 years, 3 months ago (2015-09-03 10:38:35 UTC) #11
Message was sent while issue was closed.
On 2015/08/20 17:22:31, Will Harris wrote:
> I still touch the code occasionally, and don't mind reviewing the CLs that are
> coming in - there have been a few recently because of the PGO build
> optimizations. huangs has been working a lot on it and I warned him if he
keeps
> committing CLs he might become an owner.

Any change anyone can post a build? I'm thinking of catching this before the
handover as I don't want this request to get lost between the two parties...
(TBH I'm only looking for a windows build of Courgette.. since i'm failing at
building it! =>
http://stackoverflow.com/questions/32144058/google-courgette-compiled-binary-...)

tia

Powered by Google App Engine
This is Rietveld 408576698