Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/resources/chromeos/emulator/audio_settings.html

Issue 1274403003: Full Implementation of Audio for the Chrome Os Device Emulator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initial Patch Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
michaelpg 2015/08/07 22:47:42 nit: aphabetize
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">
8
9 <dom-module id="audio-settings">
10 <link rel="import" type="css" href="audio_settings.css">
11 <template>
12 <div class="layout vertical">
13 <div class="element-label">[[title]]</div>
14 <form id="audio-settings-form">
15 <div class="layout vertical">
16 <span class="form-label">Nodes</span>
17 <template is="dom-repeat" items="[[nodes]]">
18 <div class="device-container">
19 <div class="audio-node">
20 <div class="element-label">[[item.deviceName]]</div>
21 <paper-input value="{{item.deviceName}}" label="Name"></paper-in put>
xiyuan 2015/08/07 20:17:12 nit: wrap?
mozartalouis 2015/08/07 22:44:07 Done.
22 <paper-input value="{{item.id}}" label="ID" pattern="\d{5}"
23 error-message="Invalid ID: Must be 5 digits">
xiyuan 2015/08/07 20:17:12 nit: 4-space indent.
mozartalouis 2015/08/07 22:44:07 Done.
24 </paper-input>
25 <span class="toggle-button-label">Is Input</span>
26 <paper-toggle-button checked="{{item.isInput}}"></paper-toggle-b utton>
xiyuan 2015/08/07 20:17:12 nit: wrap
mozartalouis 2015/08/07 22:44:07 Done.
27 <span class="toggle-button-label">Active</span>
28 <paper-toggle-button checked="{{item.active}}"></paper-toggle-bu tton>
xiyuan 2015/08/07 20:17:12 nit: wrap
mozartalouis 2015/08/07 22:44:07 Done.
29 <div class="device-field">
30 <label>
31 <span class="form-label">Audio Node Type</span>
32 <paper-radio-group selected="{{item.type}}">
33 <template is="dom-repeat"
34 items="[[nodeTypeOptions]]" as="option">
35 <paper-radio-button name="[[option.name]]"
36 >[[option.name]]</paper-radio-button>
xiyuan 2015/08/07 20:17:12 nit: ">" should stay with previous line.
mozartalouis 2015/08/07 22:44:07 Done.
michaelpg 2015/08/07 22:47:42 actually, this is an acceptable hacky workaround:
mozartalouis 2015/08/07 23:16:49 Acknowledged.
37 </template>
38 </paper-radio-group>
39 </label>
40 </div>
41 <paper-button raised class="colored" on-click="insertAudioNode"
42 data-index="[[index]]">Add Node</paper-button>
michaelpg 2015/08/07 22:47:42 Instead of data-index, just use event.model.index.
mozartalouis 2015/08/07 23:16:50 Done.
michaelpg 2015/08/10 16:37:23 Ah, I meant that in insertAudioNode, the event par
43 <paper-button raised class="colored" on-click="removeAudioNode"
44 data-index="[[index]]">Remove Node</paper-button>
45 </div>
46 </div>
47 </template>
48 <paper-button on-click="appendNewNode">
49 <paper-icon-button icon="add"></paper-icon-button>
50 <span>New Node</span>
51 </paper-button>
52 </div>
53 </form>
54 </div>
55 </template>
56 <script src="audio_settings.js"></script>
57 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698